From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lists.s-osg.org ([54.187.51.154]:38205 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbaK0S7b (ORCPT ); Thu, 27 Nov 2014 13:59:31 -0500 Date: Thu, 27 Nov 2014 16:59:25 -0200 From: Mauro Carvalho Chehab To: Michael Ira Krufky Cc: Linux Media Mailing List , Mauro Carvalho Chehab Subject: Re: [PATCH] [media] tda18271: Fix identation Message-ID: <20141127165925.05723c7b@recife.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Thu, 27 Nov 2014 13:47:09 -0500 Michael Ira Krufky escreveu: > On Wed, Nov 26, 2014 at 10:26 AM, Mauro Carvalho Chehab > wrote: > > As reported by smatch: > > drivers/media/tuners/tda18271-common.c:176 tda18271_read_extended() warn: if statement not indented > > > > Signed-off-by: Mauro Carvalho Chehab > > > > diff --git a/drivers/media/tuners/tda18271-common.c b/drivers/media/tuners/tda18271-common.c > > index 86e5e3110118..6118203543ea 100644 > > --- a/drivers/media/tuners/tda18271-common.c > > +++ b/drivers/media/tuners/tda18271-common.c > > @@ -173,12 +173,9 @@ int tda18271_read_extended(struct dvb_frontend *fe) > > > > for (i = 0; i < TDA18271_NUM_REGS; i++) { > > /* don't update write-only registers */ > > - if ((i != R_EB9) && > > - (i != R_EB16) && > > - (i != R_EB17) && > > - (i != R_EB19) && > > - (i != R_EB20)) > > - regs[i] = regdump[i]; > > + if ((i != R_EB9) && (i != R_EB16) && (i != R_EB17) && > > + (i != R_EB19) && (i != R_EB20)) > > + regs[i] = regdump[i]; > > } > > > > if (tda18271_debug & DBG_REG) > > -- > > 1.9.3 > > > > Mauro, > > I would actually rather NOT merge this patch. This hurts the > readability of the code. If applied already, please revert it. What hurts readability is to not indent regs[i] = regdump[i]; > > Cheers, > > Mike