From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:44441 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751072AbaLHCAJ (ORCPT ); Sun, 7 Dec 2014 21:00:09 -0500 Date: Mon, 8 Dec 2014 04:00:02 +0200 From: Sakari Ailus To: Philipp Zabel Cc: Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Boris Brezillon , linux-media@vger.kernel.org, kernel@pengutronix.de, Emil Renner Berthing Subject: Re: [PATCH 3/3] Add RGB666_1X24_CPADHI media bus format Message-ID: <20141208020002.GH15559@valkosipuli.retiisi.org.uk> References: <1417602500-29152-1-git-send-email-p.zabel@pengutronix.de> <1417602500-29152-3-git-send-email-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417602500-29152-3-git-send-email-p.zabel@pengutronix.de> Sender: linux-media-owner@vger.kernel.org List-ID: Hi Philipp, On Wed, Dec 03, 2014 at 11:28:20AM +0100, Philipp Zabel wrote: > Commit 9e74d2926a28 ("staging: imx-drm: add LVDS666 support for parallel > display") describes a 24-bit bus format where three 6-bit components each > take the lower part of 8 bits with the two high bits zero padded. Add a > component-wise padded media bus format RGB666_1X24_CPADHI to support this > connection. > > Cc: Emil Renner Berthing > Signed-off-by: Philipp Zabel > --- > Documentation/DocBook/media/v4l/subdev-formats.xml | 30 ++++++++++++++++++++++ > include/uapi/linux/media-bus-format.h | 1 + > 2 files changed, 31 insertions(+) > > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml > index 9afb846..c259b9e 100644 > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml > @@ -469,6 +469,36 @@ > b1 > b0 > > + > + MEDIA_BUS_FMT_RGB666_1X24_CPADHI s/_/-/ > + 0x1015 > + > + &dash-ent-8; > + 0 > + 0 > + r5 > + r4 > + r3 > + r2 > + r1 > + r0 > + 0 > + 0 > + g5 > + g4 > + g3 > + g2 > + g1 > + g0 > + 0 > + 0 > + b5 > + b4 > + b3 > + b2 > + b1 > + b0 > + Could you add a note on CPADHI in the documentation above, under "Packed RGB Formats", please? This could be an addition to the PADHI/PADHI bullet IMO. > > MEDIA_BUS_FMT_RGB888_1X24 > 0x100a > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index 977316e..ec80fb8 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -45,6 +45,7 @@ > #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007 > #define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008 > #define MEDIA_BUS_FMT_RGB666_1X18 0x1009 > +#define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015 > #define MEDIA_BUS_FMT_RGB666_LVDS_SPWG 0x1010 > #define MEDIA_BUS_FMT_RGB888_1X24 0x100a > #define MEDIA_BUS_FMT_BGR888_1X24 0x1013 -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk