From: Mark Brown <broonie@kernel.org>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Antti Palosaari <crope@iki.fi>,
linux-media@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCHv2 1/2] regmap: add configurable lock class key for lockdep
Date: Mon, 22 Dec 2014 15:32:03 +0000 [thread overview]
Message-ID: <20141222153203.GZ17800@sirena.org.uk> (raw)
In-Reply-To: <20141222122319.4eefacb3@concha.lan.sisa.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On Mon, Dec 22, 2014 at 12:23:19PM -0200, Mauro Carvalho Chehab wrote:
> What this patch does is to offer a way for drivers B and C to define
> different mutex groups (e. g. different mutex "IDs") that will teach
> the lockdep code to threat regmap mutex on drivers B and C as different
> mutexes.
> I hope the above explanation helps.
No, not really - even the best explanation on the mailing list isn't
going to make the commit clearer (something like this needs to be at
least clear in the commit log and ideally the code) and it'd be much
better if the interface were improved so it's obvious that users are
doing the right thing when they use it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-12-22 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 22:34 [PATCHv2 1/2] regmap: add configurable lock class key for lockdep Antti Palosaari
2014-12-20 22:34 ` [PATCHv2 2/2] rtl2832: use custom lock class key for regmap Antti Palosaari
2014-12-22 12:44 ` [PATCHv2 1/2] regmap: add configurable lock class key for lockdep Mark Brown
2014-12-22 12:55 ` Antti Palosaari
2014-12-22 13:31 ` Mark Brown
2014-12-22 13:53 ` Antti Palosaari
2014-12-22 15:05 ` Mark Brown
2015-02-02 14:31 ` Mauro Carvalho Chehab
2015-02-03 12:06 ` Mark Brown
2014-12-22 14:23 ` Mauro Carvalho Chehab
2014-12-22 15:32 ` Mark Brown [this message]
2014-12-22 20:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222153203.GZ17800@sirena.org.uk \
--to=broonie@kernel.org \
--cc=crope@iki.fi \
--cc=lars@metafoo.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).