From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:56208 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752954AbbLFBAp (ORCPT ); Sat, 5 Dec 2015 20:00:45 -0500 From: Laurent Pinchart To: Hans Verkuil Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v8 41/55] [media] DocBook: update descriptions for the media controller entities Date: Sun, 06 Dec 2015 03:00:57 +0200 Message-ID: <2014911.aPaHEit1JK@avalon> In-Reply-To: <55F2D37A.2060503@xs4all.nl> References: <00369c40b69f5ce1473d98398e32a7842cf28366.1441540862.git.mchehab@osg.samsung.com> <55F2D37A.2060503@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hello, On Friday 11 September 2015 15:13:30 Hans Verkuil wrote: > On 09/06/2015 02:03 PM, Mauro Carvalho Chehab wrote: > > Cleanup the media controller entities description: > > - remove MEDIA_ENT_T_DEVNODE and MEDIA_ENT_T_V4L2_SUBDEV entity > > types, as they don't mean anything; > > - add MEDIA_ENT_T_UNKNOWN with a proper description; > > - remove ALSA and FB entity types. Those should not be used, as > > the types are deprecated. We'll soon be adidng ALSA, but with > > a different entity namespace; > > - improve the description of some entities. > > > > Signed-off-by: Mauro Carvalho Chehab > > > > diff --git a/Documentation/DocBook/media/v4l/media-ioc-enum-entities.xml > > b/Documentation/DocBook/media/v4l/media-ioc-enum-entities.xml index > > 32a783635649..bc101516e372 100644 > > --- a/Documentation/DocBook/media/v4l/media-ioc-enum-entities.xml > > +++ b/Documentation/DocBook/media/v4l/media-ioc-enum-entities.xml > > @@ -179,70 +179,65 @@ > > > > > > > > - MEDIA_ENT_T_DEVNODE > > - Unknown device node > > + MEDIA_ENT_T_UNKNOWN and > > MEDIA_ENT_T_V4L2_SUBDEV_UNKNOWN + > > Unknown entity. That generally indicates that > > + a driver didn't initialize properly the entity, with is a Kernel > > bug> > > > > I'm wondering: if userspace should never see an unknown entity, wouldn't it > be better to move these UNKNOWN defines out of the public header to a kernel > header and drop this from the documentation? And shouldn't the bug be caught in kernelspace before it reaches the user ? > > > > MEDIA_ENT_T_V4L2_VIDEO > > - V4L video, radio or vbi device node > > + V4L video streaming input or output entity > > > > - > > - MEDIA_ENT_T_DEVNODE_FB > > - Frame buffer device node > > + MEDIA_ENT_T_V4L2_VBI > > + V4L VBI streaming input or output entity > > > > - > > - MEDIA_ENT_T_DEVNODE_ALSA > > - ALSA card > > + MEDIA_ENT_T_V4L2_SWRADIO > > + V4L Sofware Digital Radio (SDR) streaming input or output > > entity > > s/Sofware/Software/ > > > > > > > MEDIA_ENT_T_DVB_DEMOD > > - DVB frontend devnode > > + DVB demodulator entity > > > > > > MEDIA_ENT_T_DVB_DEMUX > > - DVB demux devnode > > + DVB demux entity. Could be implemented on hardware or in > > Kernelspace s/Could be/Can be/ > s/on/in/ > > > > > > > MEDIA_ENT_T_DVB_TSOUT > > - DVB DVR devnode > > + DVB Transport Stream output entity > > > > > > MEDIA_ENT_T_DVB_CA > > - DVB CAM devnode > > + DVB Conditional Access module (CAM) entity > > > > > > MEDIA_ENT_T_DVB_DEMOD_NET_DECAP > > - DVB network devnode > > - > > - > > - MEDIA_ENT_T_V4L2_SUBDEV > > - Unknown V4L sub-device > > + DVB network ULE/MLE desencapsulation entity. Could be > > implemented on hardware or in Kernelspace s/Could be/Can be/ > s/on/in/ > > Hmm, is desencapsulation correct? Could it be 'de-encapsulation' instead? It > looks weird. > > > > > > > MEDIA_ENT_T_V4L2_SUBDEV_SENSOR > > - Video sensor > > + Camera video sensor entity s/video sensor/image sensor/ > > > > > > MEDIA_ENT_T_V4L2_SUBDEV_FLASH > > - Flash controller > > + Flash controller entity > > > > > > MEDIA_ENT_T_V4L2_SUBDEV_LENS > > - Lens controller > > + Lens controller entity > > > > > > MEDIA_ENT_T_V4L2_SUBDEV_DECODER > > - Video decoder, the basic function of the video decoder is to > > - accept analogue video from a wide variety of sources such as > > + Analog video decoder, the basic function of the video decoder > > + is to accept analogue video from a wide variety of sources such as > > broadcast, DVD players, cameras and video cassette recorders, in > > - either NTSC, PAL or HD format and still occasionally SECAM, separate > > - it into its component parts, luminance and chrominance, and output > > + either NTSC, PAL, SECAM or HD format, separating the stream > > + into its component parts, luminance and chrominance, and output > > it in some digital video standard, with appropriate embedded timing > > signals. Does timing signals refer to synchronization signals ? They don't have to be embedded, do they ? > > > > > > MEDIA_ENT_T_V4L2_SUBDEV_TUNER > > - TV and/or radio tuner > > + Digital TV, analog TV, radio and/or software radio > > tuner> > > > > > > -- Regards, Laurent Pinchart