From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] dvb-usb: fix spaces after commas
Date: Tue, 3 Feb 2015 18:20:54 -0200 [thread overview]
Message-ID: <20150203182054.39e647f4@recife.lan> (raw)
In-Reply-To: <20150128151122.GA22122@goodgumbo.baconseed.org>
Em Wed, 28 Jan 2015 16:11:22 +0100
Luis de Bethencourt <luis@debethencourt.com> escreveu:
Please provide some description
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
Also, if you're touching on those printks, you should be fixing the
scripts/checkpatch.pl warnings for that too:
WARNING: line over 80 characters
#28: FILE: drivers/media/usb/dvb-usb/dvb-usb-dvb.c:87:
+ deb_ts("start pid: 0x%04x, feedtype: %d\n", dvbdmxfeed->pid, dvbdmxfeed->type);
WARNING: line over 80 characters
#46: FILE: drivers/media/usb/dvb-usb/dvb-usb-dvb.c:111:
+ if (adap->dev->props.read_mac_address(adap->dev, adap->dvb_adap.proposed_mac) == 0)
total: 0 errors, 2 warnings, 50 lines checked
Regards,
Mauro
> ---
> drivers/media/usb/dvb-usb/dvb-usb-dvb.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb/dvb-usb-dvb.c b/drivers/media/usb/dvb-usb/dvb-usb-dvb.c
> index 719413b..c901d15 100644
> --- a/drivers/media/usb/dvb-usb/dvb-usb-dvb.c
> +++ b/drivers/media/usb/dvb-usb/dvb-usb-dvb.c
> @@ -84,14 +84,14 @@ static int dvb_usb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, int onoff)
>
> static int dvb_usb_start_feed(struct dvb_demux_feed *dvbdmxfeed)
> {
> - deb_ts("start pid: 0x%04x, feedtype: %d\n", dvbdmxfeed->pid,dvbdmxfeed->type);
> - return dvb_usb_ctrl_feed(dvbdmxfeed,1);
> + deb_ts("start pid: 0x%04x, feedtype: %d\n", dvbdmxfeed->pid, dvbdmxfeed->type);
> + return dvb_usb_ctrl_feed(dvbdmxfeed, 1);
> }
>
> static int dvb_usb_stop_feed(struct dvb_demux_feed *dvbdmxfeed)
> {
> deb_ts("stop pid: 0x%04x, feedtype: %d\n", dvbdmxfeed->pid, dvbdmxfeed->type);
> - return dvb_usb_ctrl_feed(dvbdmxfeed,0);
> + return dvb_usb_ctrl_feed(dvbdmxfeed, 0);
> }
>
> int dvb_usb_adapter_dvb_init(struct dvb_usb_adapter *adap, short *adapter_nums)
> @@ -108,8 +108,8 @@ int dvb_usb_adapter_dvb_init(struct dvb_usb_adapter *adap, short *adapter_nums)
> adap->dvb_adap.priv = adap;
>
> if (adap->dev->props.read_mac_address) {
> - if (adap->dev->props.read_mac_address(adap->dev,adap->dvb_adap.proposed_mac) == 0)
> - info("MAC address: %pM",adap->dvb_adap.proposed_mac);
> + if (adap->dev->props.read_mac_address(adap->dev, adap->dvb_adap.proposed_mac) == 0)
> + info("MAC address: %pM", adap->dvb_adap.proposed_mac);
> else
> err("MAC address reading failed.");
> }
> @@ -128,7 +128,7 @@ int dvb_usb_adapter_dvb_init(struct dvb_usb_adapter *adap, short *adapter_nums)
> adap->demux.stop_feed = dvb_usb_stop_feed;
> adap->demux.write_to_decoder = NULL;
> if ((ret = dvb_dmx_init(&adap->demux)) < 0) {
> - err("dvb_dmx_init failed: error %d",ret);
> + err("dvb_dmx_init failed: error %d", ret);
> goto err_dmx;
> }
>
> @@ -136,13 +136,13 @@ int dvb_usb_adapter_dvb_init(struct dvb_usb_adapter *adap, short *adapter_nums)
> adap->dmxdev.demux = &adap->demux.dmx;
> adap->dmxdev.capabilities = 0;
> if ((ret = dvb_dmxdev_init(&adap->dmxdev, &adap->dvb_adap)) < 0) {
> - err("dvb_dmxdev_init failed: error %d",ret);
> + err("dvb_dmxdev_init failed: error %d", ret);
> goto err_dmx_dev;
> }
>
> if ((ret = dvb_net_init(&adap->dvb_adap, &adap->dvb_net,
> &adap->demux.dmx)) < 0) {
> - err("dvb_net_init failed: error %d",ret);
> + err("dvb_net_init failed: error %d", ret);
> goto err_net_init;
> }
>
prev parent reply other threads:[~2015-02-03 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 15:11 [PATCH] [media] dvb-usb: fix spaces after commas Luis de Bethencourt
2015-02-03 20:20 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203182054.39e647f4@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luis@debethencourt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).