* [PATCH] media: bcm2048: remove unused return of function
@ 2015-02-08 22:29 Luis de Bethencourt
2015-02-09 9:17 ` Pali Rohár
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-02-08 22:29 UTC (permalink / raw)
To: linux-media
Cc: devel, linux-kernel, mchehab, gregkh, hans.verkuil, pavel,
pali.rohar, wsa, luke.hart, askb23
Integer return of bcm2048_parse_rds_rt () is never used, changing the return
type to void.
Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 5382506..7f3d528 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -1579,7 +1579,7 @@ static void bcm2048_parse_rt_match_d(struct bcm2048_device *bdev, int i,
bcm2048_parse_rds_rt_block(bdev, i, index+2, crc);
}
-static int bcm2048_parse_rds_rt(struct bcm2048_device *bdev)
+static void bcm2048_parse_rds_rt(struct bcm2048_device *bdev)
{
int i, index = 0, crc, match_b = 0, match_c = 0, match_d = 0;
@@ -1615,8 +1615,6 @@ static int bcm2048_parse_rds_rt(struct bcm2048_device *bdev)
match_b = 1;
}
}
-
- return 0;
}
static void bcm2048_parse_rds_ps_block(struct bcm2048_device *bdev, int i,
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: bcm2048: remove unused return of function
2015-02-08 22:29 [PATCH] media: bcm2048: remove unused return of function Luis de Bethencourt
@ 2015-02-09 9:17 ` Pali Rohár
0 siblings, 0 replies; 2+ messages in thread
From: Pali Rohár @ 2015-02-09 9:17 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-media, devel, linux-kernel, mchehab, gregkh, hans.verkuil,
pavel, wsa, luke.hart, askb23
[-- Attachment #1: Type: Text/Plain, Size: 451 bytes --]
On Sunday 08 February 2015 23:29:11 Luis de Bethencourt wrote:
> Integer return of bcm2048_parse_rds_rt () is never used,
> changing the return type to void.
>
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Looks good,
Acked-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-09 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 22:29 [PATCH] media: bcm2048: remove unused return of function Luis de Bethencourt
2015-02-09 9:17 ` Pali Rohár
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).