Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

David Cimbůrek
2015-02-24T10:09:26Z

>> Hi,
>>
>> I looked at this again and I still don't see why the order is important.
>> Plus the code looks like it does what it should be doing when using
>> RC_SCANCODE_NEC, RC_SCANCODE_NEC32, RC_SCANCODE_NECX and RC_SCANCODE_RC5.
>>
>> Unfortunately I can't review this if I am not sure about it, and I don't
>> have the device to be able to properly test your patch.
>>
>> Hopefully your print of the scancodes helps.
>>
>> Luis
>
> Hi,
>
> unfortunately I don't understand the code very well but it really
> works like I described.
>
> I tried to get debugging output from the
> dib0700_core.c:dib0700_rc_urb_completion() function:
>
> deb_data("IR ID = %02X state = %02X System = %02X %02X Cmd = %02X %02X
> (len %d)\n",
> poll_reply->report_id, poll_reply->data_state,
> poll_reply->system, poll_reply->not_system,
> poll_reply->data, poll_reply->not_data,
> purb->actual_length);
>
> And the output after my patch (and before commit
> af3a4a9bbeb00df3e42e77240b4cdac5479812f9!) looks like this:
>
> [ 282.842557] IR ID = 01 state = 01 System = 07 00 Cmd = 0F F0 (len 6)
> [ 282.955810] IR ID = 01 state = 02 System = 07 00 Cmd = 0F F0 (len 6)
>
> But without my patch the output looks after commit
> af3a4a9bbeb00df3e42e77240b4cdac5479812f9 like this:
>
> [ 186.302282] IR ID = 01 state = 01 System = 00 07 Cmd = 0F F0 (len 6)
> [ 186.415660] IR ID = 01 state = 02 System = 00 07 Cmd = 0F F0 (len 6)
>
> You can see that the content of "system" and "not_system" is really switched...
>
> Regards,
> David

Is there anything more I can do? Shall I provide some more debugging
outputs? There is no response nearly for two weeks...