From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Mauro Carvalho Chehab" <mchehab@infradead.org>,
"Antti Palosaari" <crope@iki.fi>,
"Matthias Schwarzott" <zzam@gentoo.org>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Rafael Lourenço de Lima Chehab" <chehabrafael@gmail.com>
Subject: Re: [PATCH 1/2] [media] dvbdev: use adapter arg for dvb_create_media_graph()
Date: Mon, 2 Mar 2015 11:34:01 -0300 [thread overview]
Message-ID: <20150302113401.47208e75@recife.lan> (raw)
In-Reply-To: <54F46E83.2010008@xs4all.nl>
Em Mon, 02 Mar 2015 15:06:59 +0100
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> Hi Mauro,
>
> Small nitpick:
>
> > extern void dvb_unregister_device (struct dvb_device *dvbdev);
> > -void dvb_create_media_graph(struct media_device *mdev);
> > +
> > +#ifdef CONFIG_MEDIA_CONTROLLER_DVB
> > +void dvb_create_media_graph(struct dvb_adapter *adap);
> > +#else
> > +static inline void dvb_create_media_graph(struct dvb_adapter *adap) {};
>
> Unnecessary trailing ';'.
>
> Regards,
>
> Hans
>
Fixed, thanks!
Regards,
Mauro
prev parent reply other threads:[~2015-03-02 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 14:02 [PATCH 1/2] [media] dvbdev: use adapter arg for dvb_create_media_graph() Mauro Carvalho Chehab
2015-03-02 14:02 ` [PATCH 2/2] [media] dvb: Avoid warnings when compiled without the media controller Mauro Carvalho Chehab
2015-03-02 14:06 ` [PATCH 1/2] [media] dvbdev: use adapter arg for dvb_create_media_graph() Hans Verkuil
2015-03-02 14:34 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302113401.47208e75@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=chehabrafael@gmail.com \
--cc=crope@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=zzam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox