From: Jonathan Corbet <corbet@lwn.net>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 00/18] marvell-ccic + ov7670 fixes
Date: Tue, 10 Mar 2015 10:30:00 -0400 [thread overview]
Message-ID: <20150310103000.7d79bb7f@lwn.net> (raw)
In-Reply-To: <1425936143-5658-1-git-send-email-hverkuil@xs4all.nl>
On Mon, 9 Mar 2015 22:22:05 +0100
Hans Verkuil <hverkuil@xs4all.nl> wrote:
> This patch series makes loads of fixes and improvements to the marvell-ccic
> and ov7670 drivers. This has been tested on an OLPC XO-1 laptop.
So I'm traveling and even shorter on time than usual. I've had a quick
look over these patches, and they generally seem OK. Just don't ding me
for not using a bunch of infrastructure that wasn't there when I wrote
this thing! :)
Ideally it would be nice to see patch 9 split - locking changes separate
from use of helpers - but that's a quibble.
Out of curiosity, is there a use driving this work, or are you just
making things cleaner?
Regardless, it clearly improves the drivers; thanks for doing this.
Acked-by: Jonathan Corbet <corbet@lwn.net>
> I do need to check the last patch with Libin Yang since his patch from mid-2013
> broke the driver for the OLPC laptop. Nobody noticed since the latest released
> kernel from the OLPC project for that laptop is 3.3, which didn't have his patch.
Libin seems to have vanished, and I think that whatever interest Marvell
had in supporting this driver has vanished with him, unfortunately. I'm
still tempted to revert much of that work, since I'm not sure it has ever
worked on a real system...
jon
next prev parent reply other threads:[~2015-03-10 14:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 21:22 [PATCH 00/18] marvell-ccic + ov7670 fixes Hans Verkuil
2015-03-09 21:22 ` [PATCH 01/18] marvell-ccic: fix vb2 warning Hans Verkuil
2015-03-09 21:22 ` [PATCH 02/18] marvell-ccic: fill in bus_info Hans Verkuil
2015-03-09 21:22 ` [PATCH 03/18] marvell-ccic: webcam drivers shouldn't support g/s_std Hans Verkuil
2015-03-09 21:22 ` [PATCH 04/18] ov7670: check for valid width/height in ov7670_enum_frame_interval Hans Verkuil
2015-03-09 21:22 ` [PATCH 05/18] marvell-ccic: fill in colorspace Hans Verkuil
2015-03-09 21:22 ` [PATCH 06/18] marvell-ccic: control handler fixes Hans Verkuil
2015-03-09 21:22 ` [PATCH 07/18] marvell-ccic: switch to struct v4l2_fh Hans Verkuil
2015-03-09 21:22 ` [PATCH 08/18] marvell-ccic: implement control events Hans Verkuil
2015-03-09 21:22 ` [PATCH 09/18] marvell-ccic: use vb2 helpers and core locking Hans Verkuil
2015-03-09 21:22 ` [PATCH 10/18] marvell-ccic: add create_bufs support Hans Verkuil
2015-03-09 21:22 ` [PATCH 11/18] marvell-ccic: add DMABUF support for all three DMA modes Hans Verkuil
2015-03-09 21:22 ` [PATCH 12/18] marvell-ccic: fix streaming issues Hans Verkuil
2015-03-09 21:22 ` [PATCH 13/18] marvell-ccic: correctly requeue buffers Hans Verkuil
2015-03-09 21:22 ` [PATCH 14/18] marvell-ccic: add planar support to dma-vmalloc Hans Verkuil
2015-03-09 21:22 ` [PATCH 15/18] marvell-ccic: drop V4L2_PIX_FMT_JPEG dead code Hans Verkuil
2015-03-09 21:22 ` [PATCH 16/18] ov7670: use colorspace SRGB instead of JPEG Hans Verkuil
2015-03-09 21:22 ` [PATCH 17/18] marvell-ccic: fix the bytesperline and sizeimage calculations Hans Verkuil
2015-03-09 21:22 ` [PATCH 18/18] marvell-ccic: fix Y'CbCr ordering Hans Verkuil
2015-03-10 15:56 ` Hans Verkuil
2015-03-10 14:30 ` Jonathan Corbet [this message]
2015-03-10 14:49 ` [PATCH 00/18] marvell-ccic + ov7670 fixes Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310103000.7d79bb7f@lwn.net \
--to=corbet@lwn.net \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox