From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Josh Wu <josh.wu@atmel.com>
Subject: Re: [PATCH/RFC 4/4] soc-camera: Skip v4l2 clock registration if host doesn't provide clk ops
Date: Mon, 16 Mar 2015 16:43:12 +0900 [thread overview]
Message-ID: <20150316074306.GA18193@verge.net.au> (raw)
In-Reply-To: <1634321.iE70ufz1gl@avalon>
Hi,
On Mon, Mar 16, 2015 at 02:00:25AM +0200, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Sunday 15 March 2015 18:56:44 Guennadi Liakhovetski wrote:
> > On Mon, 9 Mar 2015, Laurent Pinchart wrote:
> > > If the soc-camera host doesn't provide clock start and stop operations
> > > registering a v4l2 clock is pointless. Don't do it.
> >
> > This can introduce breakage only for camera-host drivers, that don't
> > provide .clock_start() or .clock_stop(). After your other 3 patches from
> > this patch set there will be one such driver in the tree - rcar_vin.c. I
> > wouldn't mind this patch as long as we can have an ack from an rcar_vin.c
> > maintainer. Since I don't see one in MAINTAINERS, who can ack this? Simon?
>
> I don't think we have an official maintainer. Maybe a Tested-by would be
> enough in this case ?
I am quite happy to act as the maintainer of last resort for Renesas IP
blocks and to be listed in MAINTAINERS if that is helpful.
With regards to testing, I am also happy to help there, though in this
case I would appreciate some help with a test case.
prev parent reply other threads:[~2015-03-16 7:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 6:39 [PATCH 0/4] soc-camera: Make clock start and stop operations optional Laurent Pinchart
2015-03-09 6:39 ` [PATCH 1/4] soc-camera: Unregister v4l2 clock in the OF bind error path Laurent Pinchart
2015-03-09 6:39 ` [PATCH 2/4] soc-camera: Make clock_start and clock_stop operations optional Laurent Pinchart
2015-03-09 6:39 ` [PATCH 3/4] rcar-vin: Don't implement empty optional clock operations Laurent Pinchart
2015-03-09 6:39 ` [PATCH/RFC 4/4] soc-camera: Skip v4l2 clock registration if host doesn't provide clk ops Laurent Pinchart
2015-03-15 17:56 ` Guennadi Liakhovetski
2015-03-16 0:00 ` Laurent Pinchart
2015-03-16 7:43 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316074306.GA18193@verge.net.au \
--to=horms@verge.net.au \
--cc=g.liakhovetski@gmx.de \
--cc=josh.wu@atmel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox