From: Benoit Parrot <bparrot@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
<linux-media@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [media] i2c: ov2659: signedness bug inov2659_set_fmt()
Date: Thu, 16 Apr 2015 10:40:08 -0500 [thread overview]
Message-ID: <20150416154008.GF24270@ti.com> (raw)
In-Reply-To: <20150415191218.GC32654@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote on Wed [2015-Apr-15 22:12:18 +0300]:
> This needs to be signed or there is a risk of hitting a forever loop.
>
> Fixes: c4c0283ab3cd ('[media] media: i2c: add support for omnivision's ov2659 sensor')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Benoit Parrot <bparrot@ti.com>
> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index edebd11..d700a1d 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
> struct v4l2_subdev_format *fmt)
> {
> struct i2c_client *client = v4l2_get_subdevdata(sd);
> - unsigned int index = ARRAY_SIZE(ov2659_formats);
> + int index = ARRAY_SIZE(ov2659_formats);
> struct v4l2_mbus_framefmt *mf = &fmt->format;
> const struct ov2659_framesize *size = NULL;
> struct ov2659 *ov2659 = to_ov2659(sd);
prev parent reply other threads:[~2015-04-16 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 19:12 [media] i2c: ov2659: signedness bug inov2659_set_fmt() Dan Carpenter
2015-04-16 10:03 ` Lad, Prabhakar
2015-04-16 15:40 ` Benoit Parrot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416154008.GF24270@ti.com \
--to=bparrot@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox