* [PATCH] radio-bcm2048: remove unused var
@ 2015-04-28 12:03 Mauro Carvalho Chehab
2015-04-28 12:05 ` Pavel Machek
2015-04-28 12:07 ` Pali Rohár
0 siblings, 2 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2015-04-28 12:03 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Mauro Carvalho Chehab, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Hans Verkuil, Pali Rohár, Pavel Machek, Navya Sri Nizamkari,
Luke Hart, Anil Belur, Haneen Mohammed, Vaishali Thakkar, devel
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_i2c_driver_probe':
drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable 'skip_release' set but not used [-Wunused-but-set-variable]
int err, skip_release = 0;
^
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index e9d0691b21d3..5e11a78ceef3 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2593,7 +2593,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct bcm2048_device *bdev;
- int err, skip_release = 0;
+ int err;
bdev = kzalloc(sizeof(*bdev), GFP_KERNEL);
if (!bdev) {
@@ -2646,7 +2646,6 @@ free_sysfs:
bcm2048_sysfs_unregister_properties(bdev, ARRAY_SIZE(attrs));
free_registration:
video_unregister_device(&bdev->videodev);
- skip_release = 1;
free_irq:
if (client->irq)
free_irq(client->irq, bdev);
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] radio-bcm2048: remove unused var
2015-04-28 12:03 [PATCH] radio-bcm2048: remove unused var Mauro Carvalho Chehab
@ 2015-04-28 12:05 ` Pavel Machek
2015-04-28 12:07 ` Pali Rohár
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2015-04-28 12:05 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Hans Verkuil, Pali Rohár,
Navya Sri Nizamkari, Luke Hart, Anil Belur, Haneen Mohammed,
Vaishali Thakkar, devel
On Tue 2015-04-28 09:03:41, Mauro Carvalho Chehab wrote:
> drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_i2c_driver_probe':
> drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable 'skip_release' set but not used [-Wunused-but-set-variable]
> int err, skip_release = 0;
> ^
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index e9d0691b21d3..5e11a78ceef3 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2593,7 +2593,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct bcm2048_device *bdev;
> - int err, skip_release = 0;
> + int err;
>
> bdev = kzalloc(sizeof(*bdev), GFP_KERNEL);
> if (!bdev) {
> @@ -2646,7 +2646,6 @@ free_sysfs:
> bcm2048_sysfs_unregister_properties(bdev, ARRAY_SIZE(attrs));
> free_registration:
> video_unregister_device(&bdev->videodev);
> - skip_release = 1;
> free_irq:
> if (client->irq)
> free_irq(client->irq, bdev);
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] radio-bcm2048: remove unused var
2015-04-28 12:03 [PATCH] radio-bcm2048: remove unused var Mauro Carvalho Chehab
2015-04-28 12:05 ` Pavel Machek
@ 2015-04-28 12:07 ` Pali Rohár
1 sibling, 0 replies; 3+ messages in thread
From: Pali Rohár @ 2015-04-28 12:07 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Hans Verkuil, Pavel Machek,
Navya Sri Nizamkari, Luke Hart, Anil Belur, Haneen Mohammed,
Vaishali Thakkar, devel
On Tuesday 28 April 2015 09:03:41 Mauro Carvalho Chehab wrote:
> drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_i2c_driver_probe':
> drivers/staging/media/bcm2048/radio-bcm2048.c:2596:11: warning: variable 'skip_release' set but not used [-Wunused-but-set-variable]
> int err, skip_release = 0;
> ^
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index e9d0691b21d3..5e11a78ceef3 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2593,7 +2593,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct bcm2048_device *bdev;
> - int err, skip_release = 0;
> + int err;
>
> bdev = kzalloc(sizeof(*bdev), GFP_KERNEL);
> if (!bdev) {
> @@ -2646,7 +2646,6 @@ free_sysfs:
> bcm2048_sysfs_unregister_properties(bdev, ARRAY_SIZE(attrs));
> free_registration:
> video_unregister_device(&bdev->videodev);
> - skip_release = 1;
> free_irq:
> if (client->irq)
> free_irq(client->irq, bdev);
Looks good to me, so
Acked-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-28 12:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-28 12:03 [PATCH] radio-bcm2048: remove unused var Mauro Carvalho Chehab
2015-04-28 12:05 ` Pavel Machek
2015-04-28 12:07 ` Pali Rohár
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox