From: Jonathan Corbet <corbet@lwn.net>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 08/27] ov7670: check read error also for REG_AECHH on ov7670_s_exp()
Date: Thu, 30 Apr 2015 10:59:10 -0600 [thread overview]
Message-ID: <20150430105910.1c12af50@lwn.net> (raw)
In-Reply-To: <ff849563e43277ddf2cf83309963c74ca4428f7d.1430348725.git.mchehab@osg.samsung.com>
On Wed, 29 Apr 2015 20:05:53 -0300
Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote:
> ov7670_s_exp() checks read error for 2 registers: REG_COM1
> and REG_COM8. But, although it uses the value latter, it
> doesn't check errors on REG_AECHH read. Yet, as it is doing
> a bitmask operation there, the read operation should succeed.
>
> So, fix the code to also check if this succeeded.
>
> This fixes this smatch report:
> drivers/media/i2c/ov7670.c:1366 ov7670_s_exp() warn: inconsistent indenting
That's why I like programming in Python...:)
Silly mistake, good fix.
Acked-by: Jonathan Corbet <corbet@lwn.net>
jon
next prev parent reply other threads:[~2015-04-30 16:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 23:05 [PATCH 01/27] qt1010: avoid going past array Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 02/27] mantis: remove dead code Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 03/27] tda1004x: fix identation Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 04/27] r820t: fix identing Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 05/27] bttv: fix indenting Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 06/27] zl10353: " Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 07/27] stv0297: change typecast to u64 to avoid smatch warnings Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 08/27] ov7670: check read error also for REG_AECHH on ov7670_s_exp() Mauro Carvalho Chehab
2015-04-30 16:59 ` Jonathan Corbet [this message]
2015-04-29 23:05 ` [PATCH 09/27] cx231xx: fix bad indenting Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 10/27] dib3000mc: " Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 11/27] dib0070: Fix indenting Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 12/27] go7007: Comment some dead code Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 13/27] vp702x: comment " Mauro Carvalho Chehab
2015-04-29 23:05 ` [PATCH 14/27] redrat3: change return argument on redrat3_send_cmd() to int Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 15/27] sonixj: fix bad indenting Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 16/27] stk014: " Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 17/27] pvrusb2: fix inconsistent indenting Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 18/27] cx25840: fix bad identing Mauro Carvalho Chehab
2015-04-30 10:17 ` Lad, Prabhakar
2015-04-29 23:06 ` [PATCH 19/27] stv0900: fix bad indenting Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 20/27] s5h1420: use only one statement per line Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 21/27] tda10086: change typecast to u64 to avoid smatch warnings Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 22/27] bttv: fix audio hooks Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 23/27] ttusb-dec: fix bad indentation Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 24/27] s5p-mfc: " Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 25/27] usbvision: " Mauro Carvalho Chehab
2015-04-30 6:19 ` Hans Verkuil
2015-04-29 23:06 ` [PATCH 26/27] saa7134: fix bad indenting Mauro Carvalho Chehab
2015-04-29 23:06 ` [PATCH 27/27] dib0700: fix bad indentation Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430105910.1c12af50@lwn.net \
--to=corbet@lwn.net \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox