Re: [RFC][PATCH] rtl2832: PID filter support for slave demod

[Mauro Carvalho Chehab <mchehab@osg.samsung.com>]

Em Tue, 17 Mar 2015 00:16:06 +0100
Benjamin Larsson <benjamin@southpole.se> escreveu:

> On 03/16/2015 11:57 PM, Antti Palosaari wrote:
> > On 03/17/2015 12:12 AM, Benjamin Larsson wrote:
> >> Is this structure ok for the slave pid implementation? Or should there
> >> be only one filters parameter? Will the overlaying pid filter framework
> >> properly "flush" the set pid filters ?
> >>
> >> Note that this code currently is only compile tested.
> >
> > I am fine with it.
> >
> > byw. Have you tested if your QAM256 (DVB-C or DVB-T2) stream is valid
> > even without a PID filtering? IIRC mine stream is correct and PID
> > filtering is not required (but surely it could be implemented if you wish).
> >
> > regards
> > Antti
> >
> 
> DVB-C seems fine and one of my DVB-T2 muxes is fine also. But one other 
> DVB-T2 mux completely fails. It could be the reception but it might be 
> that it needs pid filtering. I do get small disturbances on my DVB-C 
> muxes. Will report back if pid filtering makes things better or not.

What's the status of this patch?

Btw, checkpatch.pl complains about a few things there:

WARNING: 'transfering' may be misspelled - perhaps 'transferring'?
#31: capable of transfering.

ERROR: "foo* bar" should be "foo *bar"
#77: FILE: drivers/media/dvb-frontends/rtl2832.c:1162:
+	unsigned long* filters;

WARNING: braces {} are not necessary for any arm of this statement
#93: FILE: drivers/media/dvb-frontends/rtl2832.c:1176:
+	if (onoff) {
[...]
+	} else {
[...]

total: 1 errors, 2 warnings, 87 lines checked

For now, as it was sent as RFC, I'll tag as such at patchwork.

If this is patch is pertinent, please re-send it (with the coding style
issues pointed by checkpatch.pl fixed).

Regards,
Mauro

> 
> MvH
> Benjamin Larsson
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html