* [patch] [media] m88ds3103: a couple missing error codes
@ 2015-06-02 10:20 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-06-02 10:20 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
We need to set some error codes here.
Fixes: f01919e8f54f ('[media] m88ds3103: add I2C client binding')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c
index 01b9ded..7b21f1a 100644
--- a/drivers/media/dvb-frontends/m88ds3103.c
+++ b/drivers/media/dvb-frontends/m88ds3103.c
@@ -1563,6 +1563,7 @@ static int m88ds3103_probe(struct i2c_client *client,
u8tmp = 0x10;
break;
default:
+ ret = -EINVAL;
goto err_kfree;
}
@@ -1590,8 +1591,10 @@ static int m88ds3103_probe(struct i2c_client *client,
dev->i2c_adapter = i2c_add_mux_adapter(client->adapter, &client->dev,
dev, 0, 0, 0, m88ds3103_select,
m88ds3103_deselect);
- if (dev->i2c_adapter == NULL)
+ if (dev->i2c_adapter == NULL) {
+ ret = -ENOMEM;
goto err_kfree;
+ }
/* create dvb_frontend */
memcpy(&dev->fe.ops, &m88ds3103_ops, sizeof(struct dvb_frontend_ops));
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-02 10:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-02 10:20 [patch] [media] m88ds3103: a couple missing error codes Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).