From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sunil Shahu <shshahu@gmail.com>
Cc: mchehab@osg.samsung.com, devel@driverdev.osuosl.org,
hamohammed.sa@gmail.com, arnd@arndb.de,
tapaswenipathak@gmail.com, gregkh@linuxfoundation.org,
jarod@wilsonet.com, gulsah.1004@gmail.com,
amber.rose.thrall@gmail.com, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: media: lirc: fix coding style error
Date: Fri, 19 Jun 2015 11:02:32 +0300 [thread overview]
Message-ID: <20150619080232.GN28762@mwanda> (raw)
In-Reply-To: <1434544292-32742-1-git-send-email-shshahu@gmail.com>
On Wed, Jun 17, 2015 at 06:01:32PM +0530, Sunil Shahu wrote:
> Fix code indentation error by replacing tab in place of spaces.
>
> Signed-off-by: Sunil Shahu <shshahu@gmail.com>
> ---
> drivers/staging/media/lirc/lirc_sasem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
> index 8ebee96..12aae72 100644
> --- a/drivers/staging/media/lirc/lirc_sasem.c
> +++ b/drivers/staging/media/lirc/lirc_sasem.c
> @@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
> __func__, retval);
> else
> dev_info(&context->dev->dev,
> - "Deregistered Sasem driver (minor:%d)\n", minor);
> + "Deregistered Sasem driver (minor:%d)\n", minor);
Not quite. The original is:
[tab][tab][space][space][space][space][space][space][space][space][space]"Dere...
You have:
[tab][tab][tab]"Deregistered Sasem driver ...
It should be:
[tab][tab][tab][space]"Deregistered Sasem driver (minor:%d)\n", minor);
regards,
dan carpenter
next prev parent reply other threads:[~2015-06-19 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 12:31 [PATCH] staging: media: lirc: fix coding style error Sunil Shahu
2015-06-19 8:02 ` Dan Carpenter [this message]
2015-06-19 8:42 ` Sunil Shahu
2015-06-19 8:52 ` Sunil Shahu
2015-06-19 14:05 ` Sudip Mukherjee
2015-06-20 8:53 ` [PATCH v2] " Sunil Shahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619080232.GN28762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=amber.rose.thrall@gmail.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gulsah.1004@gmail.com \
--cc=hamohammed.sa@gmail.com \
--cc=jarod@wilsonet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=shshahu@gmail.com \
--cc=tapaswenipathak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox