public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [Patch 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting
@ 2015-06-29 19:42 Benoit Parrot
  2015-06-29 19:46 ` Felipe Balbi
  0 siblings, 1 reply; 2+ messages in thread
From: Benoit Parrot @ 2015-06-29 19:42 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: Prabhakar Lad, linux-media, linux-kernel, Benoit Parrot

Upon a S_FMT the input/requeated frame size and pixel format is
overwritten by the current subdevice settings.
Fix this so application can actually set the frame size and format.

Signed-off-by: Benoit Parrot <bparrot@ti.com>
---
 drivers/media/platform/am437x/am437x-vpfe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
index eb25c43..0fa62c5 100644
--- a/drivers/media/platform/am437x/am437x-vpfe.c
+++ b/drivers/media/platform/am437x/am437x-vpfe.c
@@ -1584,7 +1584,7 @@ static int vpfe_s_fmt(struct file *file, void *priv,
 		return -EBUSY;
 	}
 
-	ret = vpfe_try_fmt(file, priv, fmt);
+	ret = vpfe_try_fmt(file, priv, &format);
 	if (ret)
 		return ret;
 
-- 
1.8.5.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting
  2015-06-29 19:42 [Patch 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting Benoit Parrot
@ 2015-06-29 19:46 ` Felipe Balbi
  0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2015-06-29 19:46 UTC (permalink / raw)
  To: Benoit Parrot; +Cc: Hans Verkuil, Prabhakar Lad, linux-media, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

On Mon, Jun 29, 2015 at 02:42:20PM -0500, Benoit Parrot wrote:
> Upon a S_FMT the input/requeated frame size and pixel format is
> overwritten by the current subdevice settings.
> Fix this so application can actually set the frame size and format.
> 
> Signed-off-by: Benoit Parrot <bparrot@ti.com>

likewise, stable ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-29 19:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-29 19:42 [Patch 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting Benoit Parrot
2015-06-29 19:46 ` Felipe Balbi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox