From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pradheep Shrinivasan <pradheep.sh@gmail.com>
Cc: Jarod Wilson <jarod@wilsonet.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Tapasweni Pathak <tapaswenipathak@gmail.com>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Subject: Re: [PATCH 1/2] staging:media:lirc Remove the extra braces in if statement of lirc_imon
Date: Mon, 3 Aug 2015 11:25:52 +0300 [thread overview]
Message-ID: <20150803082552.GT5180@mwanda> (raw)
In-Reply-To: <1438588592-3289-1-git-send-email-pradheep.sh@gmail.com>
Normally, I wait overnight between writing a patch and sending it.
There is no rush and the delay helps me to be more careful.
The subject is still not perfect. Do:
git log --oneline drivers/staging/media/lirc/lirc_imon.c
On Mon, Aug 03, 2015 at 02:56:31AM -0500, Pradheep Shrinivasan wrote:
> From: pradheep <pradheep.sh@gmail.com>
This is still wrong.
regards,
dan carpenter
next prev parent reply other threads:[~2015-08-03 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 7:56 [PATCH 1/2] staging:media:lirc Remove the extra braces in if statement of lirc_imon Pradheep Shrinivasan
2015-08-03 7:56 ` [PATCH 2/2] staging:media:lirc This fix changes the spaces to tab in lirc_sasem.c Pradheep Shrinivasan
2015-08-03 8:25 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-08-05 5:14 [PATCH 1/2] staging: media: lirc Remove the extra braces in if statement of lirc_imon Pradheep Shrinivasan
2015-08-05 5:45 ` Sudip Mukherjee
2015-08-05 5:17 Pradheep Shrinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803082552.GT5180@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarod@wilsonet.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=pradheep.sh@gmail.com \
--cc=tapaswenipathak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox