From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Junsu Shin <jjunes0@gmail.com>
Cc: mchehab@osg.samsung.com, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, boris.brezillon@free-electrons.com,
linux-kernel@vger.kernel.org, prabhakar.csengg@gmail.com,
hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com,
s.nawrocki@samsung.com, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.
Date: Fri, 7 Aug 2015 10:15:05 +0530 [thread overview]
Message-ID: <20150807044505.GB3537@sudip-pc> (raw)
In-Reply-To: <1438916154-5840-1-git-send-email-jjunes0@gmail.com>
On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote:
> This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl.
> Signed-off-by: Junsu Shin <jjunes0@gmail.com>
please do not use whitespace before Signed-off-by: line.
>
> ---
> drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> index 1bbb90c..57cd274 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
> * @fse: pointer to v4l2_subdev_frame_size_enum structure.
> */
> static int
> -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
> - struct v4l2_subdev_frame_size_enum *fse)
> +ipipe_enum_frame_size(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg,
> + struct v4l2_subdev_frame_size_enum *fse)
since you are modifying this line, please fix up the indention also.
regards
sudip
next prev parent reply other threads:[~2015-08-07 4:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 2:55 [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue Junsu Shin
2015-08-07 4:45 ` Sudip Mukherjee [this message]
2015-08-08 6:55 ` Junsu Shin
2015-08-08 10:12 ` Sudip Mukherjee
2015-08-08 15:42 ` Greg KH
2015-08-08 17:06 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807044505.GB3537@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=jjunes0@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=prabhakar.csengg@gmail.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox