public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: media-workshop@linuxtv.org, linux-media@vger.kernel.org
Subject: Re: [media-workshop] [RFC] Media graph flow for an hybrid device as discussed at the media workshop
Date: Mon, 10 Aug 2015 10:19:36 -0300	[thread overview]
Message-ID: <20150810101936.238ad3f7@recife.lan> (raw)
In-Reply-To: <20150810100524.09fb089f@recife.lan>

Em Mon, 10 Aug 2015 10:05:24 -0300
Mauro Carvalho Chehab <mchehab@osg.samsung.com> escreveu:

> Em Mon, 10 Aug 2015 14:43:50 +0200
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> 
> > Hi Mauro,
> 
> Thanks for the review!
> 
> > 
> > On 08/08/2015 01:33 PM, Mauro Carvalho Chehab wrote:
> > > During the discussions at the Media Workshop, we came with some dot files that
> > > would describe a hybrid PC-consumer TV stick with radio, analog video, analog
> > > TV and digital TV on it.
> > > 
> > > I consolidated all the dot files we've worked there, and added the
> > > connectors for RF, S-Video and Composite.
> > > 
> > > The dot file and the corresponding picture is at:
> > > 	http://linuxtv.org/downloads/presentations/mc_ws_2015/dvb-pipeline-v2.dot
> > > 	http://linuxtv.org/downloads/presentations/mc_ws_2015/dvb-pipeline-v2.png
> > > 
> > > As my plan is to start working on some real driver to produce such graph,
> > > please validate if the entities, interfaces, data links and interface links
> > > are correct, and if the namespace nomenclature is ok, or if I miss something.
> > 
> > This looks OK to me, except for one small detail: I wouldn't use the name
> > "Source entities" for connectors. Instead use "Connector entities" since
> > such entities correspond to actual real connectors on a backplane. 
> 
> Yeah. Well, they're actually "Source connector entities" ;) But I see
> your point. All connectors should be marked with a different type at
> the media_graph_obj.
> 
> > A proper
> > source entity would be a sensor or test pattern generator. Which actually
> > can occur with the em28xx since it's used in webcams as well.
> 
> Ah, true. I'll add that in the graph and use a different color to
> distinguish between "source" and "connector" entities.
> 
> > 
> > And a really, really small detail: in the legend the 'interface link' is an
> > arrow, but it should be a line, since there is no direction. The graph itself
> > is fine.
> 
> Well, I didn't find a way to put a line there. The legend is produced by
> an html code. I would need to have a "line" character, or to add an image.
> 
> Perhaps I should look deeper to find a bold horizontal line at the UTF-8
> charset. &#8212; and &#8213; are too thin. Do you know any char that would
> look better there?

Found one character ;)

I also added a webcam sensor and fixed the legend. See below:

http://linuxtv.org/downloads/presentations/mc_ws_2015/dvb-pipeline-v3.png
http://linuxtv.org/downloads/presentations/mc_ws_2015/dvb-pipeline-v3.dot

> 
> > As you mentioned on irc, the v4l-subdevX nodes won't be created for this device
> > since all the configuration happens via the standard interfaces.
> > 
> > But if they were to be created, then they would appear where they are in this
> > example.
> 
> Thanks!
> Mauro
> 
> > 
> > Regards,
> > 
> > 	Hans
> > 
> > _______________________________________________
> > media-workshop mailing list
> > media-workshop@linuxtv.org
> > http://www.linuxtv.org/cgi-bin/mailman/listinfo/media-workshop

  reply	other threads:[~2015-08-10 13:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-08 11:33 [RFC] Media graph flow for an hybrid device as discussed at the media workshop Mauro Carvalho Chehab
2015-08-10 12:43 ` Hans Verkuil
2015-08-10 13:05   ` [media-workshop] " Mauro Carvalho Chehab
2015-08-10 13:19     ` Mauro Carvalho Chehab [this message]
2015-08-10 13:44       ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150810101936.238ad3f7@recife.lan \
    --to=mchehab@osg.samsung.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=media-workshop@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox