linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: media:lirc: Added a newline character after declaration
@ 2015-08-12 15:11 Aparna Karuthodi
  2015-08-12 15:49 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Aparna Karuthodi @ 2015-08-12 15:11 UTC (permalink / raw)
  To: kdasaparna; +Cc: jarod, mchehab, gregkh, linux-media, linux-kernel, devel

Added a newline character to remove a coding style warning detected
by checkpatch.

The warning is given below:
drivers/staging/media/lirc/lirc_serial.c:1169: WARNING: quoted string split
across lines

Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
 drivers/staging/media/lirc/lirc_serial.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_serial.c b/drivers/staging/media/lirc/lirc_serial.c
index 19628d0..628577f 100644
--- a/drivers/staging/media/lirc/lirc_serial.c
+++ b/drivers/staging/media/lirc/lirc_serial.c
@@ -1165,7 +1165,7 @@ module_init(lirc_serial_init_module);
 module_exit(lirc_serial_exit_module);
 
 MODULE_DESCRIPTION("Infra-red receiver driver for serial ports.");
-MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff, "
+MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff,\n"
 	      "Christoph Bartelmus, Andrei Tanas");
 MODULE_LICENSE("GPL");
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: media:lirc: Added a newline character after declaration
  2015-08-12 15:11 [PATCH] staging: media:lirc: Added a newline character after declaration Aparna Karuthodi
@ 2015-08-12 15:49 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-08-12 15:49 UTC (permalink / raw)
  To: Aparna Karuthodi; +Cc: devel, mchehab, jarod, linux-kernel, linux-media

On Wed, Aug 12, 2015 at 08:41:42PM +0530, Aparna Karuthodi wrote:
> Added a newline character to remove a coding style warning detected
> by checkpatch.
> 
> The warning is given below:
> drivers/staging/media/lirc/lirc_serial.c:1169: WARNING: quoted string split
> across lines
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
>  drivers/staging/media/lirc/lirc_serial.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_serial.c b/drivers/staging/media/lirc/lirc_serial.c
> index 19628d0..628577f 100644
> --- a/drivers/staging/media/lirc/lirc_serial.c
> +++ b/drivers/staging/media/lirc/lirc_serial.c
> @@ -1165,7 +1165,7 @@ module_init(lirc_serial_init_module);
>  module_exit(lirc_serial_exit_module);
>  
>  MODULE_DESCRIPTION("Infra-red receiver driver for serial ports.");
> -MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff, "
> +MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff,\n"
>  	      "Christoph Bartelmus, Andrei Tanas");

No, you just changed the way this string looks, that's not ok at all.

This is fine the way it is, you can ignore it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-12 15:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-12 15:11 [PATCH] staging: media:lirc: Added a newline character after declaration Aparna Karuthodi
2015-08-12 15:49 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).