From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-f173.google.com ([209.85.212.173]:33013 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614AbbH1G6e (ORCPT ); Fri, 28 Aug 2015 02:58:34 -0400 Received: by wieo17 with SMTP id o17so4849944wie.0 for ; Thu, 27 Aug 2015 23:58:33 -0700 (PDT) Date: Fri, 28 Aug 2015 07:58:30 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.coquelin@st.com, srinivas.kandagatla@gmail.com, patrice.chotard@st.com, mchehab@osg.samsung.com, devicetree@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2 3/5] [media] c8sectpfe: Remove select on undefined LIBELF_32 Message-ID: <20150828065830.GE4796@x1> References: <1440678575-21646-1-git-send-email-peter.griffin@linaro.org> <1440678575-21646-4-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440678575-21646-4-git-send-email-peter.griffin@linaro.org> Sender: linux-media-owner@vger.kernel.org List-ID: On Thu, 27 Aug 2015, Peter Griffin wrote: > LIBELF_32 is not defined in Kconfig, and is left over legacy > which is not required in the upstream driver, so remove it. > > Signed-off-by: Peter Griffin > Suggested-by: Valentin Rothberg These are the wrong way round, they should be in chronological order. > --- > drivers/media/platform/sti/c8sectpfe/Kconfig | 1 - > 1 file changed, 1 deletion(-) Acked-by: Lee Jones > diff --git a/drivers/media/platform/sti/c8sectpfe/Kconfig b/drivers/media/platform/sti/c8sectpfe/Kconfig > index d1bfd4c..b9ec667 100644 > --- a/drivers/media/platform/sti/c8sectpfe/Kconfig > +++ b/drivers/media/platform/sti/c8sectpfe/Kconfig > @@ -1,7 +1,6 @@ > config DVB_C8SECTPFE > tristate "STMicroelectronics C8SECTPFE DVB support" > depends on DVB_CORE && I2C && (ARCH_STI || ARCH_MULTIPLATFORM) > - select LIBELF_32 > select FW_LOADER > select FW_LOADER_USER_HELPER_FALLBACK > select DEBUG_FS -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog