From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-f179.google.com ([209.85.212.179]:38559 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753408AbbIAH6P (ORCPT ); Tue, 1 Sep 2015 03:58:15 -0400 Received: by wiclp12 with SMTP id lp12so21129394wic.1 for ; Tue, 01 Sep 2015 00:58:14 -0700 (PDT) Date: Tue, 1 Sep 2015 08:58:11 +0100 From: Lee Jones To: Rob Herring Cc: Peter Griffin , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Mauro Carvalho Chehab , "devicetree@vger.kernel.org" , hugues.fruchet@st.com, "linux-media@vger.kernel.org" , valentinrothberg@gmail.com Subject: Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Message-ID: <20150901075811.GK4796@x1> References: <1440784362-31217-1-git-send-email-peter.griffin@linaro.org> <1440784362-31217-5-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, 31 Aug 2015, Rob Herring wrote: > On Fri, Aug 28, 2015 at 12:52 PM, Peter Griffin > wrote: > > gpio.txt documents that GPIO properties should be named > > "[-]gpios", with being the purpose of this > > GPIO for the device. > > > > This change has been done as one atomic commit. > > dtb and kernel updates are not necessarily atomic, so you are breaking > compatibility with older dtbs. You should certainly highlight that in > the commit message. Good idea. > I only point this out. I'll leave it to platform > maintainers whether or not this breakage is acceptable. This driver is new. The 'original' bindings are in next. So this binding is not even close to being ABI. [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog