From: Sebastian Reichel <sre@kernel.org>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCHv5 10/13] hackrf: add support for transmitter
Date: Mon, 12 Oct 2015 17:42:38 +0200 [thread overview]
Message-ID: <20151012154238.GA28125@earth> (raw)
In-Reply-To: <561A753D.8010600@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
Hi,
On Sun, Oct 11, 2015 at 05:42:05PM +0300, Antti Palosaari wrote:
> Moikka!
> IMHO it is false positive. Variable which is defined on line 777 is used
> just few lines later on line 782 as can be seen easily. I think it is
> because option CONFIG_DYNAMIC_DEBUG is not set => dev_dbg_ratelimited()
> macro is likely just NOP and gives that warning. Maybe some more logic to is
> needed in order to avoid that kind of warnings.
You can flag it with __maybe_unused:
struct usb_interface __maybe_unused *intf = dev->intf;
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-12 15:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 16:50 [PATCHv5 00/13] SDR transmitter API Antti Palosaari
2015-10-10 16:50 ` [PATCHv5 01/13] v4l2: rename V4L2_TUNER_ADC to V4L2_TUNER_SDR Antti Palosaari
2015-10-10 16:50 ` [PATCHv5 02/13] v4l2: add RF gain control Antti Palosaari
2015-10-10 16:50 ` [PATCHv5 03/13] DocBook: document tuner " Antti Palosaari
2015-10-10 16:51 ` [PATCHv5 04/13] v4l2: add support for SDR transmitter Antti Palosaari
2015-10-10 16:51 ` [PATCHv5 05/13] DocBook: document " Antti Palosaari
2015-10-10 16:51 ` [PATCHv5 06/13] v4l: add type field to v4l2_modulator struct Antti Palosaari
2015-10-10 16:51 ` [PATCHv5 07/13] DocBook: add modulator type field Antti Palosaari
2015-10-10 16:51 ` [PATCHv5 08/13] hackrf: add control for RF amplifier Antti Palosaari
2015-10-10 16:51 ` [PATCHv5 09/13] hackrf: switch to single function which configures everything Antti Palosaari
2015-10-10 16:51 ` [PATCHv5 10/13] hackrf: add support for transmitter Antti Palosaari
2015-10-11 0:55 ` kbuild test robot
2015-10-11 14:42 ` Antti Palosaari
2015-10-12 15:42 ` Sebastian Reichel [this message]
2015-10-10 16:51 ` [PATCHv5 11/13] hackrf: do not set human readable name for formats Antti Palosaari
2015-10-10 16:51 ` [PATCHv5 12/13] DocBook: add SDR specific info to G_TUNER / S_TUNER Antti Palosaari
2015-10-10 16:51 ` [PATCHv5 13/13] DocBook: add SDR specific info to G_MODULATOR / S_MODULATOR Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012154238.GA28125@earth \
--to=sre@kernel.org \
--cc=crope@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).