From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lists.s-osg.org ([54.187.51.154]:39238 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbbLLPSo (ORCPT ); Sat, 12 Dec 2015 10:18:44 -0500 Date: Sat, 12 Dec 2015 13:18:39 -0200 From: Mauro Carvalho Chehab To: Sakari Ailus Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl, javier@osg.samsung.com Subject: Re: [PATCH v2 08/22] media: Use the new media_entity_graph_walk_start() Message-ID: <20151212131839.52b6994f@recife.lan> In-Reply-To: <1448824823-10372-9-git-send-email-sakari.ailus@iki.fi> References: <1448824823-10372-1-git-send-email-sakari.ailus@iki.fi> <1448824823-10372-9-git-send-email-sakari.ailus@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Sun, 29 Nov 2015 21:20:09 +0200 Sakari Ailus escreveu: Please add a description here. The patch itself looks ok. > Signed-off-by: Sakari Ailus > --- > drivers/media/media-entity.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > index bf3c31f..4161dc7 100644 > --- a/drivers/media/media-entity.c > +++ b/drivers/media/media-entity.c > @@ -492,7 +492,13 @@ __must_check int media_entity_pipeline_start(struct media_entity *entity, > > mutex_lock(&mdev->graph_mutex); > > - media_entity_graph_walk_start(graph, entity); > + ret = media_entity_graph_walk_init(&pipe->graph, mdev); > + if (ret) { > + mutex_unlock(&mdev->graph_mutex); > + return ret; > + } > + > + media_entity_graph_walk_start(&pipe->graph, entity); > > while ((entity = media_entity_graph_walk_next(graph))) { > DECLARE_BITMAP(active, MEDIA_ENTITY_MAX_PADS); > @@ -590,6 +596,8 @@ error: > break; > } > > + media_entity_graph_walk_cleanup(graph); > + > mutex_unlock(&mdev->graph_mutex); > > return ret; > @@ -623,6 +631,8 @@ void media_entity_pipeline_stop(struct media_entity *entity) > entity->pipe = NULL; > } > > + media_entity_graph_walk_cleanup(graph); > + > mutex_unlock(&mdev->graph_mutex); > } > EXPORT_SYMBOL_GPL(media_entity_pipeline_stop);