From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH][davinci] ccdc_update_raw_params() frees the wrong thing
Date: Wed, 6 Jan 2016 16:34:27 +0000 [thread overview]
Message-ID: <20160106163427.GV9938@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+V-a8v-NC9oToS5KcaGwuATAxvOaXE3p=uT769uaKoebBVeBg@mail.gmail.com>
On Tue, Jan 05, 2016 at 05:37:06PM +0000, Lad, Prabhakar wrote:
> On Sun, Dec 13, 2015 at 12:32 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > Passing a physical address to free_pages() is a bad idea.
> > config_params->fault_pxl.fpc_table_addr is set to virt_to_phys()
> > of __get_free_pages() return value; what we should pass to free_pages()
> > is its phys_to_virt(). ccdc_close() does that properly, but
> > ccdc_update_raw_params() doesn't.
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> >
> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>
> Regards,
> --Prabhakar Lad
Which tree should it go through? I can certainly put that into
vfs.git#work.misc, but it looks like a better fit for linux-media tree, or
the davinci-specific one...
next prev parent reply other threads:[~2016-01-06 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 0:32 [PATCH][davinci] ccdc_update_raw_params() frees the wrong thing Al Viro
2016-01-05 17:37 ` Lad, Prabhakar
2016-01-06 16:34 ` Al Viro [this message]
2016-01-06 17:14 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106163427.GV9938@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox