Re: [PATCH][davinci] ccdc_update_raw_params() frees the wrong thing

Lad, Prabhakar
2016-01-06T17:14:55Z

On Wed, Jan 6, 2016 at 4:34 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Tue, Jan 05, 2016 at 05:37:06PM +0000, Lad, Prabhakar wrote:
>> On Sun, Dec 13, 2015 at 12:32 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>> > Passing a physical address to free_pages() is a bad idea.
>> > config_params->fault_pxl.fpc_table_addr is set to virt_to_phys()
>> > of __get_free_pages() return value; what we should pass to free_pages()
>> > is its phys_to_virt(). ccdc_close() does that properly, but
>> > ccdc_update_raw_params() doesn't.
>> >
>> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>> >
>> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>>
>> Regards,
>> --Prabhakar Lad
>
> Which tree should it go through? I can certainly put that into
> vfs.git#work.misc, but it looks like a better fit for linux-media tree, or
> the davinci-specific one...

It needs to go linux-media tree I'll issue a pull to mauro soon.

Cheers,
--Prabhakar Lad