From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:46171 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756099AbcAIXBv (ORCPT ); Sat, 9 Jan 2016 18:01:51 -0500 Date: Sun, 10 Jan 2016 01:01:48 +0200 From: Sakari Ailus To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Sakari Ailus , "Prabhakar\"" , Ricardo Ribalda Delgado , Laurent Pinchart , Hans Verkuil , linux-media@vger.kernel.org Subject: Re: [PATCH 5/8] [media] tvp514x: Check v4l2_of_parse_endpoint() return value Message-ID: <20160109230148.GF576@valkosipuli.retiisi.org.uk> References: <1452191248-15847-1-git-send-email-javier@osg.samsung.com> <1452191248-15847-6-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452191248-15847-6-git-send-email-javier@osg.samsung.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Thu, Jan 07, 2016 at 03:27:19PM -0300, Javier Martinez Canillas wrote: > The v4l2_of_parse_endpoint() function can fail so check the return value. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/media/i2c/tvp514x.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c > index 7fa5f1e4fe37..7a1e20feade9 100644 > --- a/drivers/media/i2c/tvp514x.c > +++ b/drivers/media/i2c/tvp514x.c > @@ -1013,11 +1013,13 @@ tvp514x_get_pdata(struct i2c_client *client) > if (!endpoint) > return NULL; > > + if (v4l2_of_parse_endpoint(endpoint, &bus_cfg)) Same as in patch 6. > + goto done; > + > pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL); > if (!pdata) > goto done; > > - v4l2_of_parse_endpoint(endpoint, &bus_cfg); > flags = bus_cfg.bus.parallel.flags; > > if (flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH) -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk