Re: [GIT PULL for v4.5-rc1] media controller next gen patch series

Sudip Mukherjee
2016-01-21T09:01:57Z

On Tue, Jan 19, 2016 at 10:53:05AM -0300, Javier Martinez Canillas wrote:
> Hello,
>
> On 01/19/2016 07:20 AM, Mauro Carvalho Chehab wrote:
> >Em Tue, 19 Jan 2016 11:02:30 +0100
> >Geert Uytterhoeven <geert@linux-m68k.org> escreveu:
> >
> >>Hi Mauro,
> >>
> >>On Tue, Jan 12, 2016 at 11:43 AM, Mauro Carvalho Chehab
> >><mchehab@osg.samsung.com> wrote:
> >>>That's the second part of the media patches. It contains the media controller
> >>>next generation patches, with is the result of one year of discussions and
> >>>development. It also contains patches to enable media controller support
> >>>at the DVB subsystem.
> >>>
> >>>The goal is to improve the media controller to allow proper support for
> >>>other types of Video4Linux devices (radio and TV ones) and to extend the
> >>>media controller functionality to allow it to be used by other subsystems
> >>>like DVB, ALSA and IIO.
> >>>
> >>>In order to use the new functionality, a new ioctl is needed
> >>>(MEDIA_IOC_G_TOPOLOGY). As we're still discussing how to pack the struct
> >>>fields of this ioctl in order to avoid compat32 issues, I decided to add
> >>>a patch at the end of this series commenting out the new ioctl, in order
> >>>to postpone the addition of the new ioctl to the next Kernel version (4.6).
> >>>With that, no userspace visible changes should happen at the media
> >>>controller API, as the existing ioctls are untouched. Yet, it helps
> >>>DVB, ALSA and IIO developers to develop and test the patches adding media
> >>>controller support there, as the core will contain all required internal
> >>>changes to allow adding support for devices that belong to those
> >>>subsystems.
> >>>
> >>>Regards,
> >>>Mauro
> >>>
> >>>The following changes since commit 768acf46e1320d6c41ed1b7c4952bab41c1cde79:
> >>>
> >>> [media] rc: sunxi-cir: Initialize the spinlock properly (2015-12-23 15:51:40 -0200)
> >>>
> >>>are available in the git repository at:
> >>>
> >>> git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v4.5-2
> >>>
> >>>for you to fetch changes up to be0270ec89e6b9b49de7e533dd1f3a89ad34d205:
> >>>
> >>> [media] Postpone the addition of MEDIA_IOC_G_TOPOLOGY (2016-01-11 12:35:17 -0200)
> >>
> >>After merging this into mainline, I get the BUG_ON() and crash I reported ca.
> >>one month ago in "vsp1 BUG_ON() and crash (Re: [PATCH v9 03/12] media:
> >>Entities, pads and links)" ( https://lkml.org/lkml/2015/12/14/373).
> >
> >Not sure what happened here, as this was supposed to have fixed already.
> >I'll ask Javier to take a look into it and work with you for us to get it
> >fixed ASAP.
> >
>
> There was a bug in my patch that split the entities registration and links
> creation. I posted a fix that was already been tested by Geert:
>
> https://patchwork.linuxtv.org/patch/32675/

I will also request you to have a look at
https://patchwork.linuxtv.org/patch/32425/

without it m32r allmodconfig will be broken for rc1.

regards
sudip