From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lists.s-osg.org ([54.187.51.154]:58232 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967352AbcA1RFy (ORCPT ); Thu, 28 Jan 2016 12:05:54 -0500 Date: Thu, 28 Jan 2016 15:05:38 -0200 From: Mauro Carvalho Chehab To: Shuah Khan Cc: tiwai@suse.com, clemens@ladisch.de, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, javier@osg.samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, perex@perex.cz, arnd@arndb.de, dan.carpenter@oracle.com, tvboxspy@gmail.com, crope@iki.fi, ruchandani.tina@gmail.com, corbet@lwn.net, chehabrafael@gmail.com, k.kozlowski@samsung.com, stefanr@s5r6.in-berlin.de, inki.dae@samsung.com, jh1009.sung@samsung.com, elfring@users.sourceforge.net, prabhakar.csengg@gmail.com, sw0312.kim@samsung.com, p.zabel@pengutronix.de, ricardo.ribalda@gmail.com, labbott@fedoraproject.org, pierre-louis.bossart@linux.intel.com, ricard.wanderlof@axis.com, julian@jusst.de, takamichiho@gmail.com, dominic.sacre@gmx.de, misterpib@gmail.com, daniel@zonque.org, gtmkramer@xs4all.nl, normalperson@yhbt.net, joe@oampo.co.uk, linuxbugs@vittgam.net, johan@oljud.se, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-api@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 31/31] media: au0828 change to check media device unregister progress state Message-ID: <20160128150538.1ba8fc7c@recife.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Wed, 6 Jan 2016 13:27:20 -0700 Shuah Khan escreveu: > Change au0828_unregister_media_device() to check media > device media device unregister is in progress and avoid > calling media_device_unregister() and other cleanup done > in au0828_unregister_media_device(). > > Signed-off-by: Shuah Khan > --- > drivers/media/usb/au0828/au0828-core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c > index 886fb28..de357a2 100644 > --- a/drivers/media/usb/au0828/au0828-core.c > +++ b/drivers/media/usb/au0828/au0828-core.c > @@ -136,7 +136,9 @@ static void au0828_unregister_media_device(struct au0828_dev *dev) > > #ifdef CONFIG_MEDIA_CONTROLLER > if (dev->media_dev && > - media_devnode_is_registered(&dev->media_dev->devnode)) { > + media_devnode_is_registered(&dev->media_dev->devnode) && > + !media_device_is_unregister_in_progress(dev->media_dev)) { > + A kref would likely work better here. > media_device_unregister(dev->media_dev); > media_device_cleanup(dev->media_dev); > dev->media_dev = NULL;