Re: [RFC 3/4] media: Properly handle user pointers

Laurent Pinchart
2016-02-22T13:28:12Z

Hi Sakari,

Thank you for the patch.

On Sunday 21 February 2016 23:36:14 Sakari Ailus wrote:
> Mark pointers containing user pointers as such.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/media/media-device.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
> index 5ebb3cd..f001c27 100644
> --- a/drivers/media/media-device.c
> +++ b/drivers/media/media-device.c
> @@ -245,10 +245,10 @@ static long __media_device_get_topology(struct
> media_device *mdev, struct media_interface *intf;
> struct media_pad *pad;
> struct media_link *link;
> - struct media_v2_entity kentity, *uentity;
> - struct media_v2_interface kintf, *uintf;
> - struct media_v2_pad kpad, *upad;
> - struct media_v2_link klink, *ulink;
> + struct media_v2_entity kentity, __user *uentity;
> + struct media_v2_interface kintf, __user *uintf;
> + struct media_v2_pad kpad, __user *upad;
> + struct media_v2_link klink, __user *ulink;
> unsigned int i;
> int ret = 0;

--
Regards,

Laurent Pinchart