From: Dan Carpenter <dan.carpenter@oracle.com>
To: hverkuil@xs4all.nl
Cc: linux-media@vger.kernel.org
Subject: re: V4L/DVB (3692): Keep experimental SLICED_VBI defines under an #if 0
Date: Sat, 27 Feb 2016 13:52:04 +0300 [thread overview]
Message-ID: <20160227105204.GE14086@mwanda> (raw)
Hello Hans Verkuil,
The patch 9bc7400a9d01: "V4L/DVB (3692): Keep experimental SLICED_VBI
defines under an #if 0" from Mar 29, 2006, leads to the following
static checker warning:
drivers/media/i2c/tvp5150.c:719 tvp5150_get_vbi()
error: buffer overflow regs 5 <= 14
drivers/media/i2c/tvp5150.c
716 }
717 pos = ret & 0x0f;
718 if (pos < 0x0f)
719 type |= regs[pos].type.vbi_type;
It used to be that regs[] had 0x10 elements (or 0xf if you don't count
the empty element at the end), but we ifdef zero most of them so now
we're reading beyond the end of the array.
720 }
721
regards,
dan carpenter
reply other threads:[~2016-02-27 10:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160227105204.GE14086@mwanda \
--to=dan.carpenter@oracle.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox