linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: sh_mobile_ceu_camera, rcar_vin: Use ARCH_RENESAS
@ 2016-03-03  1:52 Simon Horman
       [not found] ` <CAMuHMdXePj4R6pw+58xKQfAqhdCBZ=8qc-fXeVsDe8APmjunGA@mail.gmail.com>
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2016-03-03  1:52 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: Laurent Pinchart, Magnus Damm, linux-media, linux-renesas-soc,
	Simon Horman

Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.

This is part of an ongoing process to migrate from ARCH_SHMOBILE to
ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 drivers/media/platform/soc_camera/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

 Based on media-tree/master

diff --git a/drivers/media/platform/soc_camera/Kconfig b/drivers/media/platform/soc_camera/Kconfig
index f2776cd415ca..20ad48458cff 100644
--- a/drivers/media/platform/soc_camera/Kconfig
+++ b/drivers/media/platform/soc_camera/Kconfig
@@ -36,7 +36,7 @@ config VIDEO_PXA27x
 config VIDEO_RCAR_VIN
 	tristate "R-Car Video Input (VIN) support"
 	depends on VIDEO_DEV && SOC_CAMERA
-	depends on ARCH_SHMOBILE || COMPILE_TEST
+	depends on ARCH_RENESAS || COMPILE_TEST
 	depends on HAS_DMA
 	select VIDEOBUF2_DMA_CONTIG
 	select SOC_CAMERA_SCALE_CROP
@@ -53,7 +53,7 @@ config VIDEO_SH_MOBILE_CSI2
 config VIDEO_SH_MOBILE_CEU
 	tristate "SuperH Mobile CEU Interface driver"
 	depends on VIDEO_DEV && SOC_CAMERA && HAS_DMA && HAVE_CLK
-	depends on ARCH_SHMOBILE || SUPERH || COMPILE_TEST
+	depends on ARCH_RENESAS || SUPERH || COMPILE_TEST
 	depends on HAS_DMA
 	select VIDEOBUF2_DMA_CONTIG
 	select SOC_CAMERA_SCALE_CROP
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: sh_mobile_ceu_camera, rcar_vin: Use ARCH_RENESAS
       [not found]   ` <20160307012755.GA22756@verge.net.au>
@ 2016-03-07  7:53     ` Geert Uytterhoeven
  2016-03-08  0:26       ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2016-03-07  7:53 UTC (permalink / raw)
  To: Simon Horman
  Cc: Guennadi Liakhovetski, Laurent Pinchart, Magnus Damm,
	Linux Media Mailing List, linux-renesas-soc

Hi Simon,

Oops, seems I dropped all CCs in my earlier reply. Fixing up...

On Mon, Mar 7, 2016 at 2:28 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Mar 03, 2016 at 09:40:07AM +0100, Geert Uytterhoeven wrote:
>> On Thu, Mar 3, 2016 at 2:52 AM, Simon Horman <horms+renesas@verge.net.au> wrote:
>> > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
>> >
>> > This is part of an ongoing process to migrate from ARCH_SHMOBILE to
>> > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
>> > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
>> >
>> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>
>> > --- a/drivers/media/platform/soc_camera/Kconfig
>> > +++ b/drivers/media/platform/soc_camera/Kconfig
>> > @@ -36,7 +36,7 @@ config VIDEO_PXA27x
>> >  config VIDEO_RCAR_VIN
>> >         tristate "R-Car Video Input (VIN) support"
>> >         depends on VIDEO_DEV && SOC_CAMERA
>> > -       depends on ARCH_SHMOBILE || COMPILE_TEST
>> > +       depends on ARCH_RENESAS || COMPILE_TEST
>>
>> OK
>>
>> >>  config VIDEO_SH_MOBILE_CEU
>> >         tristate "SuperH Mobile CEU Interface driver"
>> >         depends on VIDEO_DEV && SOC_CAMERA && HAS_DMA && HAVE_CLK
>> > -       depends on ARCH_SHMOBILE || SUPERH || COMPILE_TEST
>> > +       depends on ARCH_RENESAS || SUPERH || COMPILE_TEST
>>
>> I think dropping the SUPERH dependency is the right approach here, as all
>> SuperH platforms using this driver select ARCH_SHMOBILE.
>>
>> "sh_mobile_ceu" is used on SH_AP325RXA, SH_ECOVEC, SH_KFR2R09, SH_MIGOR,
>> and SH_7724_SOLUTION_ENGINE, which depend on either CPU_SUBTYPE_SH7722,
>>  CPU_SUBTYPE_SH7723, or
>> CPU_SUBTYPE_SH7724, and all three select ARCH_SHMOBILE.
>
> Dropping SUPERH seems fine to me. But in that case I think the following
> would be best as I would like to stop selecting ARCH_SHMOBILE for
> the ARM SoCs.
>
>         depends on ARCH_RENESAS || ARCH_SHMOBILE || COMPILE_TEST

Do we need this driver with ARCH_RENESAS? It does not support DT.

R8a7740 has the sh_mobile_ceu hardware, but support for it was dropped with
r8a7740/armadillo legacy removal.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: sh_mobile_ceu_camera, rcar_vin: Use ARCH_RENESAS
  2016-03-07  7:53     ` Geert Uytterhoeven
@ 2016-03-08  0:26       ` Simon Horman
  0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2016-03-08  0:26 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Guennadi Liakhovetski, Laurent Pinchart, Magnus Damm,
	Linux Media Mailing List, linux-renesas-soc

On Mon, Mar 07, 2016 at 08:53:56AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> Oops, seems I dropped all CCs in my earlier reply. Fixing up...
> 
> On Mon, Mar 7, 2016 at 2:28 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Mar 03, 2016 at 09:40:07AM +0100, Geert Uytterhoeven wrote:
> >> On Thu, Mar 3, 2016 at 2:52 AM, Simon Horman <horms+renesas@verge.net.au> wrote:
> >> > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
> >> >
> >> > This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> >> > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
> >> > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
> >> >
> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>
> >> > --- a/drivers/media/platform/soc_camera/Kconfig
> >> > +++ b/drivers/media/platform/soc_camera/Kconfig
> >> > @@ -36,7 +36,7 @@ config VIDEO_PXA27x
> >> >  config VIDEO_RCAR_VIN
> >> >         tristate "R-Car Video Input (VIN) support"
> >> >         depends on VIDEO_DEV && SOC_CAMERA
> >> > -       depends on ARCH_SHMOBILE || COMPILE_TEST
> >> > +       depends on ARCH_RENESAS || COMPILE_TEST
> >>
> >> OK
> >>
> >> >>  config VIDEO_SH_MOBILE_CEU
> >> >         tristate "SuperH Mobile CEU Interface driver"
> >> >         depends on VIDEO_DEV && SOC_CAMERA && HAS_DMA && HAVE_CLK
> >> > -       depends on ARCH_SHMOBILE || SUPERH || COMPILE_TEST
> >> > +       depends on ARCH_RENESAS || SUPERH || COMPILE_TEST
> >>
> >> I think dropping the SUPERH dependency is the right approach here, as all
> >> SuperH platforms using this driver select ARCH_SHMOBILE.
> >>
> >> "sh_mobile_ceu" is used on SH_AP325RXA, SH_ECOVEC, SH_KFR2R09, SH_MIGOR,
> >> and SH_7724_SOLUTION_ENGINE, which depend on either CPU_SUBTYPE_SH7722,
> >>  CPU_SUBTYPE_SH7723, or
> >> CPU_SUBTYPE_SH7724, and all three select ARCH_SHMOBILE.
> >
> > Dropping SUPERH seems fine to me. But in that case I think the following
> > would be best as I would like to stop selecting ARCH_SHMOBILE for
> > the ARM SoCs.
> >
> >         depends on ARCH_RENESAS || ARCH_SHMOBILE || COMPILE_TEST
> 
> Do we need this driver with ARCH_RENESAS? It does not support DT.
> 
> R8a7740 has the sh_mobile_ceu hardware, but support for it was dropped with
> r8a7740/armadillo legacy removal.

Silly me, no it is not needed.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-03-08  0:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03  1:52 [PATCH] media: sh_mobile_ceu_camera, rcar_vin: Use ARCH_RENESAS Simon Horman
     [not found] ` <CAMuHMdXePj4R6pw+58xKQfAqhdCBZ=8qc-fXeVsDe8APmjunGA@mail.gmail.com>
     [not found]   ` <20160307012755.GA22756@verge.net.au>
2016-03-07  7:53     ` Geert Uytterhoeven
2016-03-08  0:26       ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).