From: "Nibble Max" <nibble.max@gmail.com>
To: "Olli Salonen" <olli.salonen@iki.fi>,
"linux-media" <linux-media@vger.kernel.org>
Cc: "Olli Salonen" <olli.salonen@iki.fi>
Subject: Re: [PATCH 2/2] smipcie: MAC address printout formatting
Date: Thu, 10 Mar 2016 09:28:38 +0800 [thread overview]
Message-ID: <201603100928354688232@gmail.com> (raw)
In-Reply-To: 1457563108-17017-1-git-send-email-olli.salonen@iki.fi
Reviewed-by: Max Nibble<nibble.max@gmail.com>
On 2016-03-10 06:39:27, Olli Salonen <olli.salonen@iki.fi> wrote:
>Modify the printout for MAC address to be more vendor agnostic.
>Print also the port number.
>
>Signed-off-by: Olli Salonen <olli.salonen@iki.fi>
>---
> drivers/media/pci/smipcie/smipcie-main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/media/pci/smipcie/smipcie-main.c b/drivers/media/pci/smipcie/smipcie-main.c
>index 993a2d1..4a9275a 100644
>--- a/drivers/media/pci/smipcie/smipcie-main.c
>+++ b/drivers/media/pci/smipcie/smipcie-main.c
>@@ -716,7 +716,8 @@ static int smi_fe_init(struct smi_port *port)
> /* init MAC.*/
> ret = smi_read_eeprom(&dev->i2c_bus[0], 0xc0, mac_ee, 16);
> dev_info(&port->dev->pci_dev->dev,
>- "DVBSky SMI PCIe MAC= %pM\n", mac_ee + (port->idx)*8);
>+ "%s port %d MAC: %pM\n", dev->info->name,
>+ port->idx, mac_ee + (port->idx)*8);
> memcpy(adap->proposed_mac, mac_ee + (port->idx)*8, 6);
> return ret;
> }
>--
>1.9.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-media" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-03-10 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 22:38 [PATCH 1/2] smipcie: add support for TechnoTrend S2-4200 Twin Olli Salonen
2016-03-09 22:38 ` [PATCH 2/2] smipcie: MAC address printout formatting Olli Salonen
2016-03-10 1:28 ` Nibble Max [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201603100928354688232@gmail.com \
--to=nibble.max@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=olli.salonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).