* [patch] [media] am437x-vpfe: fix an uninitialized variable bug
@ 2016-03-15 7:04 Dan Carpenter
2016-03-15 18:28 ` Lad, Prabhakar
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-03-15 7:04 UTC (permalink / raw)
To: Lad, Prabhakar, Benoit Parrot
Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
If we are doing V4L2_FIELD_NONE then "ret" is used uninitialized.
Fixes: 417d2e507edc ('[media] media: platform: add VPFE capture driver support for AM437X')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
index de32e3a..7d14732 100644
--- a/drivers/media/platform/am437x/am437x-vpfe.c
+++ b/drivers/media/platform/am437x/am437x-vpfe.c
@@ -1047,7 +1047,7 @@ static int vpfe_get_ccdc_image_format(struct vpfe_device *vpfe,
static int vpfe_config_ccdc_image_format(struct vpfe_device *vpfe)
{
enum ccdc_frmfmt frm_fmt = CCDC_FRMFMT_INTERLACED;
- int ret;
+ int ret = 0;
vpfe_dbg(2, vpfe, "vpfe_config_ccdc_image_format\n");
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] [media] am437x-vpfe: fix an uninitialized variable bug
2016-03-15 7:04 [patch] [media] am437x-vpfe: fix an uninitialized variable bug Dan Carpenter
@ 2016-03-15 18:28 ` Lad, Prabhakar
0 siblings, 0 replies; 2+ messages in thread
From: Lad, Prabhakar @ 2016-03-15 18:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: Benoit Parrot, Mauro Carvalho Chehab, linux-media,
kernel-janitors
Hi Dan,
Thanks for the patch.
On Tue, Mar 15, 2016 at 7:04 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> If we are doing V4L2_FIELD_NONE then "ret" is used uninitialized.
>
> Fixes: 417d2e507edc ('[media] media: platform: add VPFE capture driver support for AM437X')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cheers,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-15 18:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-15 7:04 [patch] [media] am437x-vpfe: fix an uninitialized variable bug Dan Carpenter
2016-03-15 18:28 ` Lad, Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox