From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mike Isely <isely@isely.net>
Cc: linux-media@vger.kernel.org
Subject: re: file (standard input) matches
Date: Thu, 21 Apr 2016 13:15:56 +0300 [thread overview]
Message-ID: <20160421101556.GA7699@mwanda> (raw)
Hello file (standard input) matches,
The patch d855497edbfb: "V4L/DVB (4228a): pvrusb2 to kernel 2.6.18" from
Jun 26 2006, leads to the following static checker warning:
drivers/media/usb/pvrusb2/pvrusb2-hdw.c:881 ctrl_std_sym_to_val()
error: uninitialized symbol 'id'.
drivers/media/usb/pvrusb2/pvrusb2-hdw.c
873 static int ctrl_std_sym_to_val(struct pvr2_ctrl *cptr,
874 const char *bufPtr,unsigned int bufSize,
875 int *mskp,int *valp)
876 {
877 int ret;
878 v4l2_std_id id;
879 ret = pvr2_std_str_to_id(&id,bufPtr,bufSize);
880 if (ret < 0) return ret;
pvr2_std_str_to_id() appears to return 0 on error and !0 on success.
Not joking, that's the actual code.
881 if (mskp) *mskp = id;
882 if (valp) *valp = id;
883 return 0;
884 }
regards,
dan carpenter
reply other threads:[~2016-04-21 10:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421101556.GA7699@mwanda \
--to=dan.carpenter@oracle.com \
--cc=isely@isely.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox