From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 6/6] rcar-vin: failed start_streaming didn't call s_stream(0)
Date: Fri, 22 Apr 2016 20:57:27 +0200 [thread overview]
Message-ID: <20160422185726.GC23014@bigcity.dyn.berto.se> (raw)
In-Reply-To: <1461330222-34096-7-git-send-email-hverkuil@xs4all.nl>
Hi Hans,
Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
On 2016-04-22 15:03:42 +0200, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> This can leave adv7180 in an inconsistent state
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/platform/rcar-vin/rcar-dma.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c
> index 644ec9b..087c30c 100644
> --- a/drivers/media/platform/rcar-vin/rcar-dma.c
> +++ b/drivers/media/platform/rcar-vin/rcar-dma.c
> @@ -1058,8 +1058,10 @@ static int rvin_start_streaming(struct vb2_queue *vq, unsigned int count)
> ret = rvin_capture_start(vin);
> out:
> /* Return all buffers if something went wrong */
> - if (ret)
> + if (ret) {
> return_all_buffers(vin, VB2_BUF_STATE_QUEUED);
> + v4l2_subdev_call(sd, video, s_stream, 0);
> + }
>
> spin_unlock_irqrestore(&vin->qlock, flags);
>
> --
> 2.8.0.rc3
>
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2016-04-22 18:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 13:03 [PATCH 0/6] Various rcar-vin and adv* fixes Hans Verkuil
2016-04-22 13:03 ` [PATCH 1/6] adv7180: fix broken standards handling Hans Verkuil
2016-04-22 13:46 ` Federico Vaga
2016-04-22 14:19 ` Niklas Söderlund
2016-04-24 14:57 ` Lars-Peter Clausen
2016-04-22 13:03 ` [PATCH 2/6] sta2x11_vip: fix s_std Hans Verkuil
2016-04-22 13:15 ` Federico Vaga
2016-04-22 13:17 ` Hans Verkuil
2016-04-22 13:03 ` [PATCH 3/6] rcar-vin: support the source change event and " Hans Verkuil
2016-04-22 18:55 ` Niklas Söderlund
2016-04-22 13:03 ` [PATCH 4/6] tc358743: drop bogus comment Hans Verkuil
2016-04-22 13:03 ` [PATCH 5/6] media/i2c/adv*: make controls inheritable instead of private Hans Verkuil
2016-04-22 13:03 ` [PATCH 6/6] rcar-vin: failed start_streaming didn't call s_stream(0) Hans Verkuil
2016-04-22 18:57 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422185726.GC23014@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox