public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 05/13] v4l: vsp1: Add FCP support
Date: Fri, 17 Jun 2016 08:07:23 -0300	[thread overview]
Message-ID: <20160617080723.7a760bf1@recife.lan> (raw)
In-Reply-To: <1461620198-13428-6-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

Em Tue, 26 Apr 2016 00:36:30 +0300
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> escreveu:

> On some platforms the VSP performs memory accesses through an FCP. When
> that's the case get a reference to the FCP from the VSP DT node and
> enable/disable it at runtime as needed.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  .../devicetree/bindings/media/renesas,vsp1.txt      |  5 +++++
>  drivers/media/platform/Kconfig                      |  1 +
>  drivers/media/platform/vsp1/vsp1.h                  |  2 ++
>  drivers/media/platform/vsp1/vsp1_drv.c              | 21 ++++++++++++++++++++-
>  4 files changed, 28 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt b/Documentation/devicetree/bindings/media/renesas,vsp1.txt
> index 627405abd144..9b695bcbf219 100644
> --- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.txt
> @@ -14,6 +14,11 @@ Required properties:
>    - interrupts: VSP interrupt specifier.
>    - clocks: A phandle + clock-specifier pair for the VSP functional clock.
>  
> +Optional properties:
> +
> +  - renesas,fcp: A phandle referencing the FCP that handles memory accesses
> +                 for the VSP. Not needed on Gen2, mandatory on Gen3.
> +
>  
>  Example: R8A7790 (R-Car H2) VSP1-S node
>  
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index f453910050be..a3304466e628 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -264,6 +264,7 @@ config VIDEO_RENESAS_VSP1
>  	tristate "Renesas VSP1 Video Processing Engine"
>  	depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
>  	depends on (ARCH_RENESAS && OF) || COMPILE_TEST
> +	depends on !ARM64 || VIDEO_RENESAS_FCP

It sounds that this will break compile-test on ARM64 for no good reason.

Thanks,
Mauro

  reply	other threads:[~2016-06-17 11:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 21:36 [PATCH v2 00/13] R-Car VSP improvements for v4.7 - Round 2 Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 01/13] dt-bindings: Add Renesas R-Car FCP DT bindings Laurent Pinchart
2016-04-28  2:54   ` Rob Herring
2016-04-28  6:36     ` Laurent Pinchart
2016-04-28  8:00       ` Geert Uytterhoeven
2016-05-11 12:36   ` [PATCH v2.1] " Laurent Pinchart
2016-05-11 12:38     ` Geert Uytterhoeven
2016-05-11 13:05     ` Rob Herring
2016-04-25 21:36 ` [PATCH v2 02/13] v4l: Add Renesas R-Car FCP driver Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 03/13] v4l: vsp1: Implement runtime PM support Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 04/13] v4l: vsp1: Don't handle clocks manually Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 05/13] v4l: vsp1: Add FCP support Laurent Pinchart
2016-06-17 11:07   ` Mauro Carvalho Chehab [this message]
2016-06-17 14:35     ` Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 06/13] v4l: vsp1: Add output node value to routing table Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 07/13] v4l: vsp1: Replace container_of() with dedicated macro Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 08/13] v4l: vsp1: Make vsp1_entity_get_pad_compose() more generic Laurent Pinchart
2016-04-26 18:09   ` Sergei Shtylyov
2016-04-27 15:26     ` Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 09/13] v4l: vsp1: Move frame sequence number from video node to pipeline Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 10/13] v4l: vsp1: Group DRM RPF parameters in a structure Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 11/13] drm: rcar-du: Add alpha support for VSP planes Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 12/13] drm: rcar-du: Add Z-order " Laurent Pinchart
2016-04-25 21:36 ` [PATCH v2 13/13] v4l: vsp1: Remove deprecated DRM API Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160617080723.7a760bf1@recife.lan \
    --to=mchehab@s-opensource.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox