From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] tw686x: make const structs static
Date: Mon, 4 Jul 2016 11:37:43 -0300 [thread overview]
Message-ID: <20160704143743.GA23710@laptop> (raw)
In-Reply-To: <37b742cd-d308-efe9-e48c-d65bc9d24ccb@xs4all.nl>
On 01 Jul 04:39 PM, Hans Verkuil wrote:
> Fix sparse warnings:
>
> tw686x-video.c:148:29: warning: symbol 'memcpy_dma_ops' was not declared. Should it be static?
> tw686x-video.c:195:29: warning: symbol 'contig_dma_ops' was not declared. Should it be static?
> tw686x-video.c:361:29: warning: symbol 'sg_dma_ops' was not declared. Should it be static?
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Thanks!
> ---
> drivers/media/pci/tw686x/tw686x-video.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw686x/tw686x-video.c
> index 0e839f6..bae33d9 100644
> --- a/drivers/media/pci/tw686x/tw686x-video.c
> +++ b/drivers/media/pci/tw686x/tw686x-video.c
> @@ -145,7 +145,7 @@ static void tw686x_memcpy_buf_refill(struct tw686x_video_channel *vc,
> vc->curr_bufs[pb] = NULL;
> }
>
> -const struct tw686x_dma_ops memcpy_dma_ops = {
> +static const struct tw686x_dma_ops memcpy_dma_ops = {
> .alloc = tw686x_memcpy_dma_alloc,
> .free = tw686x_memcpy_dma_free,
> .buf_refill = tw686x_memcpy_buf_refill,
> @@ -192,7 +192,7 @@ static int tw686x_contig_setup(struct tw686x_dev *dev)
> return 0;
> }
>
> -const struct tw686x_dma_ops contig_dma_ops = {
> +static const struct tw686x_dma_ops contig_dma_ops = {
> .setup = tw686x_contig_setup,
> .cleanup = tw686x_contig_cleanup,
> .buf_refill = tw686x_contig_buf_refill,
> @@ -358,7 +358,7 @@ static int tw686x_sg_setup(struct tw686x_dev *dev)
> return 0;
> }
>
> -const struct tw686x_dma_ops sg_dma_ops = {
> +static const struct tw686x_dma_ops sg_dma_ops = {
> .setup = tw686x_sg_setup,
> .cleanup = tw686x_sg_cleanup,
> .alloc = tw686x_sg_dma_alloc,
> --
> 2.8.1
>
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
prev parent reply other threads:[~2016-07-04 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 14:39 [PATCH] tw686x: make const structs static Hans Verkuil
2016-07-04 14:37 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704143743.GA23710@laptop \
--to=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox