From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qt0-f176.google.com ([209.85.216.176]:36226 "EHLO mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbcGDOht (ORCPT ); Mon, 4 Jul 2016 10:37:49 -0400 Received: by mail-qt0-f176.google.com with SMTP id w59so88573212qtd.3 for ; Mon, 04 Jul 2016 07:37:48 -0700 (PDT) Date: Mon, 4 Jul 2016 11:37:43 -0300 From: Ezequiel Garcia To: Hans Verkuil Cc: Linux Media Mailing List Subject: Re: [PATCH] tw686x: make const structs static Message-ID: <20160704143743.GA23710@laptop> References: <37b742cd-d308-efe9-e48c-d65bc9d24ccb@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37b742cd-d308-efe9-e48c-d65bc9d24ccb@xs4all.nl> Sender: linux-media-owner@vger.kernel.org List-ID: On 01 Jul 04:39 PM, Hans Verkuil wrote: > Fix sparse warnings: > > tw686x-video.c:148:29: warning: symbol 'memcpy_dma_ops' was not declared. Should it be static? > tw686x-video.c:195:29: warning: symbol 'contig_dma_ops' was not declared. Should it be static? > tw686x-video.c:361:29: warning: symbol 'sg_dma_ops' was not declared. Should it be static? > > Signed-off-by: Hans Verkuil Acked-by: Ezequiel Garcia Thanks! > --- > drivers/media/pci/tw686x/tw686x-video.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw686x/tw686x-video.c > index 0e839f6..bae33d9 100644 > --- a/drivers/media/pci/tw686x/tw686x-video.c > +++ b/drivers/media/pci/tw686x/tw686x-video.c > @@ -145,7 +145,7 @@ static void tw686x_memcpy_buf_refill(struct tw686x_video_channel *vc, > vc->curr_bufs[pb] = NULL; > } > > -const struct tw686x_dma_ops memcpy_dma_ops = { > +static const struct tw686x_dma_ops memcpy_dma_ops = { > .alloc = tw686x_memcpy_dma_alloc, > .free = tw686x_memcpy_dma_free, > .buf_refill = tw686x_memcpy_buf_refill, > @@ -192,7 +192,7 @@ static int tw686x_contig_setup(struct tw686x_dev *dev) > return 0; > } > > -const struct tw686x_dma_ops contig_dma_ops = { > +static const struct tw686x_dma_ops contig_dma_ops = { > .setup = tw686x_contig_setup, > .cleanup = tw686x_contig_cleanup, > .buf_refill = tw686x_contig_buf_refill, > @@ -358,7 +358,7 @@ static int tw686x_sg_setup(struct tw686x_dev *dev) > return 0; > } > > -const struct tw686x_dma_ops sg_dma_ops = { > +static const struct tw686x_dma_ops sg_dma_ops = { > .setup = tw686x_sg_setup, > .cleanup = tw686x_sg_cleanup, > .alloc = tw686x_sg_dma_alloc, > -- > 2.8.1 > -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar