[PATCH] tw686x: make const structs static

[PATCH] tw686x: make const structs static

[Hans Verkuil]

Fix sparse warnings:

tw686x-video.c:148:29: warning: symbol 'memcpy_dma_ops' was not declared. Should it be static?
tw686x-video.c:195:29: warning: symbol 'contig_dma_ops' was not declared. Should it be static?
tw686x-video.c:361:29: warning: symbol 'sg_dma_ops' was not declared. Should it be static?

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
 drivers/media/pci/tw686x/tw686x-video.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw686x/tw686x-video.c
index 0e839f6..bae33d9 100644
--- a/drivers/media/pci/tw686x/tw686x-video.c
+++ b/drivers/media/pci/tw686x/tw686x-video.c
@@ -145,7 +145,7 @@ static void tw686x_memcpy_buf_refill(struct tw686x_video_channel *vc,
 	vc->curr_bufs[pb] = NULL;
 }

-const struct tw686x_dma_ops memcpy_dma_ops = {
+static const struct tw686x_dma_ops memcpy_dma_ops = {
 	.alloc		= tw686x_memcpy_dma_alloc,
 	.free		= tw686x_memcpy_dma_free,
 	.buf_refill	= tw686x_memcpy_buf_refill,
@@ -192,7 +192,7 @@ static int tw686x_contig_setup(struct tw686x_dev *dev)
 	return 0;
 }

-const struct tw686x_dma_ops contig_dma_ops = {
+static const struct tw686x_dma_ops contig_dma_ops = {
 	.setup		= tw686x_contig_setup,
 	.cleanup	= tw686x_contig_cleanup,
 	.buf_refill	= tw686x_contig_buf_refill,
@@ -358,7 +358,7 @@ static int tw686x_sg_setup(struct tw686x_dev *dev)
 	return 0;
 }

-const struct tw686x_dma_ops sg_dma_ops = {
+static const struct tw686x_dma_ops sg_dma_ops = {
 	.setup		= tw686x_sg_setup,
 	.cleanup	= tw686x_sg_cleanup,
 	.alloc		= tw686x_sg_dma_alloc,
-- 
2.8.1

Re: [PATCH] tw686x: make const structs static

[Ezequiel Garcia]

On 01 Jul 04:39 PM, Hans Verkuil wrote:
> Fix sparse warnings:
> 
> tw686x-video.c:148:29: warning: symbol 'memcpy_dma_ops' was not declared. Should it be static?
> tw686x-video.c:195:29: warning: symbol 'contig_dma_ops' was not declared. Should it be static?
> tw686x-video.c:361:29: warning: symbol 'sg_dma_ops' was not declared. Should it be static?
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>

Acked-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

Thanks!

> ---
>  drivers/media/pci/tw686x/tw686x-video.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw686x/tw686x-video.c
> index 0e839f6..bae33d9 100644
> --- a/drivers/media/pci/tw686x/tw686x-video.c
> +++ b/drivers/media/pci/tw686x/tw686x-video.c
> @@ -145,7 +145,7 @@ static void tw686x_memcpy_buf_refill(struct tw686x_video_channel *vc,
>  	vc->curr_bufs[pb] = NULL;
>  }
> 
> -const struct tw686x_dma_ops memcpy_dma_ops = {
> +static const struct tw686x_dma_ops memcpy_dma_ops = {
>  	.alloc		= tw686x_memcpy_dma_alloc,
>  	.free		= tw686x_memcpy_dma_free,
>  	.buf_refill	= tw686x_memcpy_buf_refill,
> @@ -192,7 +192,7 @@ static int tw686x_contig_setup(struct tw686x_dev *dev)
>  	return 0;
>  }
> 
> -const struct tw686x_dma_ops contig_dma_ops = {
> +static const struct tw686x_dma_ops contig_dma_ops = {
>  	.setup		= tw686x_contig_setup,
>  	.cleanup	= tw686x_contig_cleanup,
>  	.buf_refill	= tw686x_contig_buf_refill,
> @@ -358,7 +358,7 @@ static int tw686x_sg_setup(struct tw686x_dev *dev)
>  	return 0;
>  }
> 
> -const struct tw686x_dma_ops sg_dma_ops = {
> +static const struct tw686x_dma_ops sg_dma_ops = {
>  	.setup		= tw686x_sg_setup,
>  	.cleanup	= tw686x_sg_cleanup,
>  	.alloc		= tw686x_sg_dma_alloc,
> -- 
> 2.8.1
> 

-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar