Re: [PATCH 2/2] [media] cec: add RC_CORE dependency

Arnd Bergmann
2016-07-19T08:36:10Z

On Tuesday, July 19, 2016 10:30:22 AM CEST Hans Verkuil wrote:
> On 07/19/16 10:10, Arnd Bergmann wrote:
> > We cannot build the cec driver when the RC core is a module
> > and cec is built-in:
> >
> > drivers/staging/built-in.o: In function `cec_allocate_adapter':
> > :(.text+0x134): undefined reference to `rc_allocate_device'
> > drivers/staging/built-in.o: In function `cec_register_adapter':
> > :(.text+0x304): undefined reference to `rc_register_device'
> >
> > This adds an explicit dependency to avoid this case. We still
> > allow building when CONFIG_RC_CORE is disabled completely,
> > as the driver has checks for this case itself.
>
> This makes no sense: the rc_allocate_device and rc_register_device
> are under:
>
> #if IS_REACHABLE(CONFIG_RC_CORE)
>
> So it shouldn't be enabled at all, should it?

My mistake, I forgot to remove my patch from the backlog after
you added 5bb2399a4fe4 ("[media] cec: fix Kconfig dependency
problems"), and I saw that it's still marked as "new" in
patchwork with no reply.

I'll drop the patch from my local series and won't submit it again,
sorry for the mixup.

Arnd