From: Jonathan Corbet <corbet@lwn.net>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Markus Heiser <markus.heiser@darmarit.de>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] doc-rst: get rid of warnings at kernel-documentation.rst
Date: Wed, 20 Jul 2016 17:06:41 -0600 [thread overview]
Message-ID: <20160720170641.7836b1fe@lwn.net> (raw)
In-Reply-To: <20160720114111.55d66e07@recife.lan>
On Wed, 20 Jul 2016 11:41:11 -0300
Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:
> > The thing with that is that a lot of literal blocks *do* have C code, even
> > in kernel-documentation.rst. Setting that in conf.py would turn off all C
> > highlighting. I think that might actually be a desirable outcome, but it
> > would be good to make that decision explicitly.
>
> Agreed. Assuming "C" as default seems a good idea to me.
"Agreed," but there was an implied question there that, I think, deserves
consideration. Do we want to have a default highlighting language for
literal blocks at all? Those blocks will contain ascii art diagrams,
device-tree fragments, error message examples, and who knows what else.
Even if the majority of them are C code, having Sphinx treat all of them
as C is going to lead to a steady stream of warnings and a lot of extra
markup in the text.
Plus I'm not convinced that more color eye candy in code fragments is
actually helpful.
So I think I might actually argue in favor of Markus's suggestion and set
the language to "none" by default. But others may feel strongly about
having their bikeshed in full syntax-highlighted color. Opinions on the
matter?
Thanks,
jon
next prev parent reply other threads:[~2016-07-20 23:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 14:11 [PATCH] doc-rst: get rid of warnings at kernel-documentation.rst Mauro Carvalho Chehab
2016-07-20 14:23 ` Markus Heiser
2016-07-20 14:31 ` Jonathan Corbet
2016-07-20 14:41 ` Mauro Carvalho Chehab
2016-07-20 23:06 ` Jonathan Corbet [this message]
2016-07-21 10:22 ` Mauro Carvalho Chehab
2016-07-20 14:49 ` Markus Heiser
2016-07-20 15:06 ` Mauro Carvalho Chehab
2016-07-20 15:33 ` Markus Heiser
2016-07-21 10:25 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720170641.7836b1fe@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=markus.heiser@darmarit.de \
--cc=mchehab@infradead.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).