From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf0-f43.google.com ([209.85.215.43]:35596 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753620AbcG2UQh (ORCPT ); Fri, 29 Jul 2016 16:16:37 -0400 Received: by mail-lf0-f43.google.com with SMTP id f93so78636313lfi.2 for ; Fri, 29 Jul 2016 13:16:36 -0700 (PDT) From: "Niklas =?iso-8859-1?Q?S=F6derlund?=" Date: Fri, 29 Jul 2016 22:16:34 +0200 To: Steve Longerbeam Cc: Sergei Shtylyov , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, slongerbeam@gmail.com, lars@metafoo.de, mchehab@kernel.org, hans.verkuil@cisco.com Subject: Re: [PATCH 6/6] media: adv7180: fix field type Message-ID: <20160729201634.GC3672@bigcity.dyn.berto.se> References: <20160729174012.14331-1-niklas.soderlund+renesas@ragnatech.se> <20160729174012.14331-7-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On 2016-07-29 12:32:30 -0700, Steve Longerbeam wrote: > > On 07/29/2016 12:10 PM, Sergei Shtylyov wrote: > > On 07/29/2016 08:40 PM, Niklas Söderlund wrote: > > > > > From: Steve Longerbeam > > > > > > The ADV7180 and ADV7182 transmit whole fields, bottom field followed > > > by top (or vice-versa, depending on detected video standard). So > > > for chips that do not have support for explicitly setting the field > > > mode, set the field mode to V4L2_FIELD_ALTERNATE. > > > > > > Signed-off-by: Steve Longerbeam > > > [Niklas: changed filed type from V4L2_FIELD_SEQ_{TB,BT} to > > > V4L2_FIELD_ALTERNATE] > > > Signed-off-by: Niklas Söderlund > > > > Tested-by: Sergei Shtylyov > > > > IIUC, it's a 4th version of this patch; you should have kept the > > original change log (below --- tearline) and indicated that in the > > subject. > > > > MBR, Sergei > > This version is fine with me. The i.mx6 h/w motion-compensation deinterlacer > (VDIC) > needs to know the field order, and it can't get that info from > V4L2_FIELD_ALTERNATE, > but it can still determine the order via querystd(). > > But I agree the change log should be preserved, and the V4L2_FIELD_ALTERNATE > change > added to the change log. Yes, I will send a v2 containing the changelog. My bad for dropping it. > > Acked-by: Steve Longerbeam > > Steve > > -- Regards, Niklas Söderlund