* [PATCH 0/2] [media] tw5864 constify some structures
@ 2016-09-12 23:02 Andrey Utkin
2016-09-12 23:02 ` [PATCH 1/2] [media] tw5864: constify vb2_ops structure Andrey Utkin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andrey Utkin @ 2016-09-12 23:02 UTC (permalink / raw)
To: linux-kernel, linux-media, mchehab, hans.verkuil, Julia.Lawall
Cc: andrey_utkin, maintainers, Andrey Utkin
tw5864 is a recently submitted driver and it is currently present only
in media tree.
Recent patches submitted by Julia Lawall urged me to make similar
changes in this driver.
Andrey Utkin (2):
[media] tw5864: constify vb2_ops structure
[media] tw5864: constify struct video_device template
drivers/media/pci/tw5864/tw5864-video.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.9.2
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/2] [media] tw5864: constify vb2_ops structure
2016-09-12 23:02 [PATCH 0/2] [media] tw5864 constify some structures Andrey Utkin
@ 2016-09-12 23:02 ` Andrey Utkin
2016-09-12 23:02 ` [PATCH 2/2] [media] tw5864: constify struct video_device template Andrey Utkin
2016-09-12 23:17 ` [PATCH 0/2] [media] tw5864 constify some structures Andrey Utkin
2 siblings, 0 replies; 4+ messages in thread
From: Andrey Utkin @ 2016-09-12 23:02 UTC (permalink / raw)
To: linux-kernel, linux-media, mchehab, hans.verkuil, Julia.Lawall
Cc: andrey_utkin, maintainers, Andrey Utkin
Inspired by "[media] pci: constify vb2_ops structures" patch
from Julia Lawall (dated 9 Sep 2016).
Signed-off-by: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
---
drivers/media/pci/tw5864/tw5864-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/tw5864/tw5864-video.c b/drivers/media/pci/tw5864/tw5864-video.c
index 6c1685a..7401b64 100644
--- a/drivers/media/pci/tw5864/tw5864-video.c
+++ b/drivers/media/pci/tw5864/tw5864-video.c
@@ -465,7 +465,7 @@ static void tw5864_stop_streaming(struct vb2_queue *q)
spin_unlock_irqrestore(&input->slock, flags);
}
-static struct vb2_ops tw5864_video_qops = {
+static const struct vb2_ops tw5864_video_qops = {
.queue_setup = tw5864_queue_setup,
.buf_queue = tw5864_buf_queue,
.start_streaming = tw5864_start_streaming,
--
2.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] [media] tw5864: constify struct video_device template
2016-09-12 23:02 [PATCH 0/2] [media] tw5864 constify some structures Andrey Utkin
2016-09-12 23:02 ` [PATCH 1/2] [media] tw5864: constify vb2_ops structure Andrey Utkin
@ 2016-09-12 23:02 ` Andrey Utkin
2016-09-12 23:17 ` [PATCH 0/2] [media] tw5864 constify some structures Andrey Utkin
2 siblings, 0 replies; 4+ messages in thread
From: Andrey Utkin @ 2016-09-12 23:02 UTC (permalink / raw)
To: linux-kernel, linux-media, mchehab, hans.verkuil, Julia.Lawall
Cc: andrey_utkin, maintainers, Andrey Utkin
tw5864_video_template is used for filling of actual video_device
structures. It is copied by value, and is not used for anything else.
Signed-off-by: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
---
drivers/media/pci/tw5864/tw5864-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/tw5864/tw5864-video.c b/drivers/media/pci/tw5864/tw5864-video.c
index 7401b64..652a059 100644
--- a/drivers/media/pci/tw5864/tw5864-video.c
+++ b/drivers/media/pci/tw5864/tw5864-video.c
@@ -912,7 +912,7 @@ static const struct v4l2_ioctl_ops video_ioctl_ops = {
#endif
};
-static struct video_device tw5864_video_template = {
+static const struct video_device tw5864_video_template = {
.name = "tw5864_video",
.fops = &video_fops,
.ioctl_ops = &video_ioctl_ops,
--
2.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 0/2] [media] tw5864 constify some structures
2016-09-12 23:02 [PATCH 0/2] [media] tw5864 constify some structures Andrey Utkin
2016-09-12 23:02 ` [PATCH 1/2] [media] tw5864: constify vb2_ops structure Andrey Utkin
2016-09-12 23:02 ` [PATCH 2/2] [media] tw5864: constify struct video_device template Andrey Utkin
@ 2016-09-12 23:17 ` Andrey Utkin
2 siblings, 0 replies; 4+ messages in thread
From: Andrey Utkin @ 2016-09-12 23:17 UTC (permalink / raw)
To: Andrey Utkin
Cc: linux-kernel, linux-media, mchehab, hans.verkuil, Julia.Lawall,
maintainers
On Tue, Sep 13, 2016 at 02:02:36AM +0300, Andrey Utkin wrote:
> tw5864 is a recently submitted driver and it is currently present only
> in media tree.
Oops, have just fetched linux-next updates, tw5864 is already in next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-12 23:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-12 23:02 [PATCH 0/2] [media] tw5864 constify some structures Andrey Utkin
2016-09-12 23:02 ` [PATCH 1/2] [media] tw5864: constify vb2_ops structure Andrey Utkin
2016-09-12 23:02 ` [PATCH 2/2] [media] tw5864: constify struct video_device template Andrey Utkin
2016-09-12 23:17 ` [PATCH 0/2] [media] tw5864 constify some structures Andrey Utkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).