linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: sumit.semwal@linaro.org, arnd@arndb.de, xie.baoyou@zte.com.cn,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
Date: Tue, 20 Sep 2016 13:13:38 +0200	[thread overview]
Message-ID: <20160920111338.GE13275@joana> (raw)
In-Reply-To: <1474202961-10099-1-git-send-email-baoyou.xie@linaro.org>

2016-09-18 Baoyou Xie <baoyou.xie@linaro.org>:

> We get 1 warning when building kernel with W=1:
> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  drivers/dma-buf/sw_sync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for finding this.

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Gustavo


  reply	other threads:[~2016-09-20 11:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-18 12:49 [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Baoyou Xie
2016-09-20 11:13 ` Gustavo Padovan [this message]
2016-09-20 12:53   ` Sumit Semwal
2016-09-22  6:57     ` Greg Kroah-Hartman
2016-09-25 20:33       ` Gustavo Padovan
  -- strict thread matches above, loose matches on Subject: below --
2016-09-24  4:33 Baoyou Xie
2016-09-24  9:07 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160920111338.GE13275@joana \
    --to=gustavo@padovan.org \
    --cc=arnd@arndb.de \
    --cc=baoyou.xie@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=xie.baoyou@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).