From: Gustavo Padovan <gustavo@padovan.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sumit Semwal <sumit.semwal@linaro.org>,
Baoyou Xie <baoyou.xie@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
xie.baoyou@zte.com.cn, LKML <linux-kernel@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Linaro MM SIG Mailman List <linaro-mm-sig@lists.linaro.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static
Date: Sun, 25 Sep 2016 22:33:13 +0200 [thread overview]
Message-ID: <20160925203313.GA2571@joana> (raw)
In-Reply-To: <20160922065731.GA16298@kroah.com>
Hi Baoyou,
2016-09-22 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote:
> > Hi Baoyou,
> >
> > On 20 September 2016 at 16:43, Gustavo Padovan <gustavo@padovan.org> wrote:
> > > 2016-09-18 Baoyou Xie <baoyou.xie@linaro.org>:
> > >
> > >> We get 1 warning when building kernel with W=1:
> > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
> > >>
> > >> In fact, this function is only used in the file in which it is
> > >> declared and don't need a declaration, but can be made static.
> > >> So this patch marks it 'static'.
> > >>
> > >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> > >> ---
> > >> drivers/dma-buf/sw_sync.c | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Thanks for finding this.
> >
> > Thanks for the patch; this doesn't apply to mainline yet, since the
> > de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree.
> > CC'ing him.
> >
> > Greg, would it be possible to please take this via your tree?
>
> If someone resends it to me with the needed acks and reviewed-by, I
> will.
Could please resend this to Greg with all the acks and reviewed-by in
the commit message? Thanks.
Gustavo
next prev parent reply other threads:[~2016-09-25 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 12:49 [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Baoyou Xie
2016-09-20 11:13 ` Gustavo Padovan
2016-09-20 12:53 ` Sumit Semwal
2016-09-22 6:57 ` Greg Kroah-Hartman
2016-09-25 20:33 ` Gustavo Padovan [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-24 4:33 Baoyou Xie
2016-09-24 9:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925203313.GA2571@joana \
--to=gustavo@padovan.org \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).