From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:36134 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759810AbcIYUdQ (ORCPT ); Sun, 25 Sep 2016 16:33:16 -0400 Date: Sun, 25 Sep 2016 22:33:13 +0200 From: Gustavo Padovan To: Greg Kroah-Hartman Cc: Sumit Semwal , Baoyou Xie , Arnd Bergmann , xie.baoyou@zte.com.cn, LKML , DRI mailing list , Linaro MM SIG Mailman List , "linux-media@vger.kernel.org" Subject: Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static Message-ID: <20160925203313.GA2571@joana> References: <1474202961-10099-1-git-send-email-baoyou.xie@linaro.org> <20160920111338.GE13275@joana> <20160922065731.GA16298@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160922065731.GA16298@kroah.com> Sender: linux-media-owner@vger.kernel.org List-ID: Hi Baoyou, 2016-09-22 Greg Kroah-Hartman : > On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > > Hi Baoyou, > > > > On 20 September 2016 at 16:43, Gustavo Padovan wrote: > > > 2016-09-18 Baoyou Xie : > > > > > >> We get 1 warning when building kernel with W=1: > > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] > > >> > > >> In fact, this function is only used in the file in which it is > > >> declared and don't need a declaration, but can be made static. > > >> So this patch marks it 'static'. > > >> > > >> Signed-off-by: Baoyou Xie > > >> --- > > >> drivers/dma-buf/sw_sync.c | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Thanks for finding this. > > > > Thanks for the patch; this doesn't apply to mainline yet, since the > > de-staging of sw_sync code is queued for 4.9 via Greg-KH's tree. > > CC'ing him. > > > > Greg, would it be possible to please take this via your tree? > > If someone resends it to me with the needed acks and reviewed-by, I > will. Could please resend this to Greg with all the acks and reviewed-by in the commit message? Thanks. Gustavo