From: Sebastian Reichel <sre@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH v1.1 4/5] smiapp: Use runtime PM
Date: Tue, 27 Sep 2016 15:11:24 +0200 [thread overview]
Message-ID: <20160927131124.6w75mja2hewrrkf5@earth> (raw)
In-Reply-To: <1473980009-19377-1-git-send-email-sakari.ailus@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]
Hi,
On Fri, Sep 16, 2016 at 01:53:29AM +0300, Sakari Ailus wrote:
> Use runtime PM to manage power. The s_power() core sub-device callback is
> removed as it is no longer needed.
>
> The power management of the sensor is changed so that it is no longer
> dependent on open file descriptors on sub-device or use_count in the media
> entity but solely will be powered on as needed for probing and streaming.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> since v1:
>
> - Both smiapp_set_ctrl() and smiapp_update_mode() perform work which is
> unrelated to the power state of the device. Instead, check the power
> state in smiapp_write() which is more appropriate.
>
> - Don't explicitly disable streaming in smiapp_remove(). It'd be an
> unrelated change.
>
> drivers/media/i2c/smiapp/smiapp-core.c | 130 ++++++++++++++++-----------------
> drivers/media/i2c/smiapp/smiapp-regs.c | 5 ++
> drivers/media/i2c/smiapp/smiapp.h | 11 +--
> 3 files changed, 67 insertions(+), 79 deletions(-)
Reviewed-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-09-27 13:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 11:29 [PATCH 0/5] smiapp: Runtime PM support Sakari Ailus
2016-09-15 11:29 ` [PATCH 1/5] smiapp: Drop BUG_ON() in suspend path Sakari Ailus
2016-09-15 11:29 ` [PATCH 2/5] smiapp: Set device for pixel array and binner Sakari Ailus
2016-09-19 22:55 ` Sebastian Reichel
2016-09-15 11:29 ` [PATCH 3/5] smiapp: Set use suspend and resume ops for other functions Sakari Ailus
2016-09-19 22:54 ` Sebastian Reichel
2016-09-15 11:29 ` [PATCH 4/5] smiapp: Use runtime PM Sakari Ailus
2016-09-15 22:53 ` [PATCH v1.1 " Sakari Ailus
2016-09-19 22:51 ` Sebastian Reichel
2016-09-20 7:50 ` Sakari Ailus
2016-09-27 13:11 ` Sebastian Reichel [this message]
2016-10-03 8:55 ` [PATCH v1.2 " Sakari Ailus
2016-09-15 11:29 ` [PATCH 5/5] smiapp: Implement support for autosuspend Sakari Ailus
2016-09-19 22:53 ` Sebastian Reichel
2016-09-20 12:29 ` [PATCH v1.1 " Sakari Ailus
2016-09-23 0:14 ` Sebastian Reichel
2016-09-23 11:13 ` Sakari Ailus
2016-10-03 8:57 ` [PATCH v1.2 " Sakari Ailus
2016-10-03 9:27 ` [PATCH v1.3 " Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927131124.6w75mja2hewrrkf5@earth \
--to=sre@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).