From: Andrey Utkin <andrey_utkin@fastmail.com>
To: Harman Kalra <harman4linux@gmail.com>
Cc: laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl
Date: Mon, 3 Oct 2016 22:52:11 +0100 [thread overview]
Message-ID: <20161003215211.okrvsky5bgglm75p@acer> (raw)
In-Reply-To: <1475355646-6378-1-git-send-email-harman4linux@gmail.com>
On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote:
> static int iss_video_queue_setup(struct vb2_queue *vq,
> - unsigned int *count, unsigned int *num_planes,
> - unsigned int sizes[], struct device *alloc_devs[])
> + unsigned int *count, unsigned int *num_planes,
> + unsigned int sizes[], struct device *alloc_devs[])
2 spaces + 3 tabs -> 2 spaces + 2 tabs? Am I seeing this correctly?
Both ways are against CodingStyle.
> - /* Try the get selection operation first and fallback to get format if not
> - * implemented.
> + /* Try the get selection operation first and
> + * fallback to get format if not implemented.
> */
This comment style is discouraged so this is at lease not perfect.
Doesn't checkpatch complain with this change? If it doesn't, could you
please also check with --strict, as long as you're working on style.
next prev parent reply other threads:[~2016-10-03 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 21:00 [PATCH] [media] : Removing warnings caught by checkpatch.pl Harman Kalra
2016-10-03 9:34 ` Laurent Pinchart
2016-10-03 21:52 ` Andrey Utkin [this message]
2016-10-04 7:59 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003215211.okrvsky5bgglm75p@acer \
--to=andrey_utkin@fastmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harman4linux@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox